Fix StartActivityExecution request-ID dedup across server-side retries

Move RequestId generation before the proto clone so that the
RetryableInterceptor, which retries with the same request pointer,
carries the same server-generated RequestId on every attempt. Previously
the RequestId was generated on the clone, so each retry got a fresh UUID
that could not match the stored RequestId, breaking dedup and potentially
causing a double-create if the activity completed between attempts.

Fix Terminate/CancelActivity request-ID dedup across server-side retries

Same issue as StartActivityExecution: the RequestId was generated on a
clone, so RetryableInterceptor retries got a fresh UUID each time. For
Terminate, this caused a spurious FailedPrecondition error on retry
("already terminated with request ID ..."). For RequestCancel, same
pattern ("cancellation already requested with request ID ...").

Fix: set RequestId on the original request before any clone, matching
the OSS pattern used by workflow handlers.

These handlers had no other mutations requiring a clone, so the clone is
simply removed.

Author: dandavison

chasm/lib/activity/frontend.go

@@ -294,8 +294,6 @@ func (h *frontendHandler) TerminateActivityExecution(
 	}
 
 	if req.GetRequestId() == "" {
-		// Since this mutates the request, we clone it first so that any retries use the original request.
-		req = common.CloneProto(req)
 		req.RequestId = uuid.NewString()
 	}
 
@@ -333,8 +331,6 @@ func (h *frontendHandler) RequestCancelActivityExecution(
 	}
 
 	if req.GetRequestId() == "" {
-		// Since this mutates the request, we clone it first so that any retries use the original request.
-		req = common.CloneProto(req)
 		req.RequestId = uuid.NewString()
 	}
 
@@ -362,6 +358,9 @@ func (h *frontendHandler) validateAndPopulateStartRequest(
 	req *workflowservice.StartActivityExecutionRequest,
 	namespaceID namespace.ID,
 ) (*workflowservice.StartActivityExecutionRequest, error) {
+	if req.GetRequestId() == "" {
+		req.RequestId = uuid.NewString()
+	}
 	// Since validation includes mutation of the request, we clone it first so that any retries use the original request.
 	req = common.CloneProto(req)
 	activityType := req.ActivityType.GetName()
@@ -400,10 +399,6 @@ func (h *frontendHandler) validateAndPopulateStartRequest(
 func (h *frontendHandler) validateAndNormalizeStartActivityExecutionRequest(
 	req *workflowservice.StartActivityExecutionRequest,
 ) error {
-	if req.GetRequestId() == "" {
-		req.RequestId = uuid.NewString()
-	}
-
 	maxIDLengthLimit := h.config.MaxIDLengthLimit()
 
 	if len(req.GetRequestId()) > maxIDLengthLimit {