Reset to pending workflow task when reapplying to a closed workflow with no completed workflow task#10899
Draft
jiechenz wants to merge 2 commits into
Draft
Reset to pending workflow task when reapplying to a closed workflow with no completed workflow task#10899jiechenz wants to merge 2 commits into
jiechenz wants to merge 2 commits into
Conversation
…low task Anchor the reset to the pending workflow task when there is no completed workflow task. Resets to a real pending task (scheduled/started) are supported by the resetter; transient and speculative pending tasks are skipped as they have no persisted WorkflowTaskScheduled event. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
When replication reapplies events (e.g. signals/updates) to a closed workflow that has no completed workflow task, the reset now anchors at the workflow's pending workflow task instead of failing on the
EmptyEventIDanchorThe reset anchor is chosen as follows:
Scenarios (closed current+active workflow) and their test coverage
LastCompletedWFTStartedEventId..._ResetFailed,..._ResetErrorEmpty)..._NoWorkflowTaskBoundary..._TransientWorkflowTaskNotUsableStartedEventID..._StartedPendingWorkflowTaskScheduledEventID..._PendingWorkflowTaskWhy?
Tell your future self why have you made these changes.
How did you test it?