[testcore] Shared cluster pool for clusters that require WorkerService#10905
Draft
long-nt-tran wants to merge 1 commit into
Draft
[testcore] Shared cluster pool for clusters that require WorkerService#10905long-nt-tran wants to merge 1 commit into
long-nt-tran wants to merge 1 commit into
Conversation
long-nt-tran
force-pushed
the
system-worker-pool
branch
6 times, most recently
from
64ac31e to
db86e1e
Compare
long-nt-tran
force-pushed
the
system-worker-pool
branch
from
db86e1e to
bdd1214
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added a
sharedWithWorker, which is a reusable pool of test clusters for cluster setups that require the system workers.Why?
Right now, when a test requires system workers, we give it a dedicated cluster. However, this is heavy, and if we do this for all tests that require system workers, we risk a lot of OOM kills.
Technically speaking, reusing a cluster that has system workers is completely fine, so this PR does this by default (i.e., if we only enable system workers with no special configs, then we should aim to reuse this cluster).
For now, I'm creating a new shared pool of cluster-with-worker-service, rather than having a single shared pool, so we don't have to scan the entire pool to see which cluster is reusable.
How did you test it?
Potential risks
Also re-enabled system workers + parallelization on some existing tests that were made to be sequential to avoid OOMs, so I'll watch out for OOMs from those.