Include config file name in legacy config loader parse errors#10906
Open
sAchin-680 wants to merge 1 commit into
Open
Include config file name in legacy config loader parse errors#10906sAchin-680 wants to merge 1 commit into
sAchin-680 wants to merge 1 commit into
Conversation
Previously, errors from processConfigFile and yaml.Unmarshal in the legacy hierarchical config loader were returned bare, so failures like "did not find expected key" gave no indication of which of the loaded files (base.yaml, env.yaml, env_zone.yaml) caused them. Wrap these errors with the offending file path, matching the behavior already used by the newer WithConfigFile/WithEmbedded loading paths. Fixes temporalio#455 Signed-off-by: sAchin-680 <mrmister680@gmail.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Errors from
processConfigFileandyaml.Unmarshalin the legacy hierarchical config loader (base.yaml,env.yaml,env_zone.yaml) are now wrapped with the path of the offending file, matching the behavior already used by the newerWithConfigFile/WithEmbeddedloading paths.Why?
Previously these errors were returned bare, so a failure like "did not find expected key" gave no indication of which loaded file caused it — as reported in #455, where a customer's service failed to start with a config error that named a line number but not a file, making the issue difficult to diagnose.
Fixes #455
How did you test it?
Potential risks
None - this only adds file-path context to existing error paths; the underlying error types and control flow are unchanged.