Sync WCI compute status to worker deployment version state#10908
Open
02strich wants to merge 1 commit into
Open
Sync WCI compute status to worker deployment version state#1090802strich wants to merge 1 commit into
02strich wants to merge 1 commit into
Conversation
02strich
force-pushed
the
stefan/wci-status
branch
from
62afda2 to
2fa08f0
Compare
Contributor
|
Please consider signal with start if the concern is dropping the signal during the race. SyncVersionState is used in the hot path of changing routing configuration and I don't think we should make it depend on an external workflow unless strictly necessary. |
02strich
force-pushed
the
stefan/wci-status
branch
from
2fa08f0 to
740c944
Compare
Contributor
Author
|
@ShahabT moved it to |
02strich
force-pushed
the
stefan/wci-status
branch
from
740c944 to
b5def95
Compare
Add DescribeWorkerControllerInstanceStatus activity to fetch the WCI validation status and map it to a ComputeStatus. During handleSyncState, invoke syncVersionDataToComputeStatus to update the version state's ComputeStatus with the provider validation result. The sync is gated behind the "sync-compute-validation-status" workflow version for backward compatibility.
02strich
force-pushed
the
stefan/wci-status
branch
from
b5def95 to
106f180
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Add DescribeWorkerControllerInstanceStatus activity to fetch the WCI validation status and map it to a ComputeStatus. During handleSyncState, invoke syncVersionDataToComputeStatus to update the version state's ComputeStatus with the provider validation result. The sync is gated behind the "sync-compute-validation-status" workflow version for backward compatibility.
Why?
During creation of a new version there is a risk of the compute provider validation finishing before the version is created, and thereby the sync signal for the compute status being missed. This highlighted that there is no backstop for the status sync in this and other cases of missing the signal so adding one.
How did you test it?