Handle duplicate err in apply snapshot#9796
Open
yux0 wants to merge 3 commits intotemporalio:mainfrom
Open
Conversation
michaely520
approved these changes
Apr 3, 2026
| return err | ||
| } | ||
| if currentRunID == targetRunID { | ||
| // Need to reload the mutable state to verify the duplication |
Contributor
There was a problem hiding this comment.
nit: does this comment really make sense here? this codepath has several callers right
Contributor
Author
There was a problem hiding this comment.
I will remove this comment
| } | ||
| ) | ||
|
|
||
| func NewSequentialTaskQueue(task TrackableExecutableTask) ctasks.SequentialTaskQueue[TrackableExecutableTask] { |
Contributor
Author
There was a problem hiding this comment.
yes. I don't see anywhere use it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Handle duplicate err in apply snapshot
Why?
We cannot simply return duplication if the mutable state is null. We need to reload the mutable state and retry it.
How did you test it?
Potential risks
Minor risk. This will retry one more to reload the mutable state.