Add idempotency tests for repeated ShutdownWorker/CancelOutstandingWorkerPolls calls#9818
Open
Add idempotency tests for repeated ShutdownWorker/CancelOutstandingWorkerPolls calls#9818
Conversation
Verify that CancelOutstandingWorkerPolls and ShutdownWorker can be called multiple times safely: cancel functions are only invoked once, the shutdown cache persists, and subsequent polls are still rejected. Made-with: Cursor
rkannan82
requested review from
ShahabT and
carlydf
and removed request for
carlydf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Add idempotency tests for
CancelOutstandingWorkerPollsandShutdownWorker— unit test and functional test confirming repeated calls are safe and the shutdown cache remains effective.Why?
The SDK may call
ShutdownWorkermultiple times. We should have explicit coverage for this.How did you test it?
Potential risks
None — test-only changes.