fix(conformance): tidy Go adapter deps for local SDK#45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Go SDK conformance adapter setup for SDK PRs that change transitive dependencies.
The reusable SDK conformance workflow edits the Go adapter to replace
github.com/tempoxyz/mpp-gowith the PR checkout. After that replace, the adapter module still needs to refresh its module graph; otherwise Go builds fail with missinggo.sumentries for dependencies from the local SDK checkout.Validation:
python3 -m py_compile conformance/scripts/use_local_sdk.pyfigtracer/mpp-go:codex/body-digest-server-conformance:use_local_sdk.py --adapter go,go mod download, andgo build -o adapter .Observed affected
mpp-goPRs:github.com/redis/go-redis/v9sumgithub.com/redis/go-redis/v9sum