fix(ci): resolve foundry lockfile conflicts after reth bumps in foundry-patch.sh#3884
Merged
Merged
Conversation
fgimenez
added
C-test
0xrusowsky
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a reth bump tightens a constraint on a transitive crate already pinned in foundry's lockfile (e.g. reth requires
alloy-eip7928 ^0.3.6while foundry's lock has0.3.5),cargo metadatafails andForge Test (Rust Precompiles)breaks for any PR that touches
tips/verify/**,crates/contracts/**, orcrates/precompiles/**.Example failure https://github.com/tempoxyz/tempo/actions/runs/25663969326/job/75331584394
This PR makes
scripts/foundry-patch.shparse the conflicting package out of thecargo metadataerror, runcargo update -p <pkg>for it, and retry. Loops while there are pending conflicts and bails out if the same crate fails twice in a row.