Receivers with positional-only parameters should be cacheable

tenderlove · tenderlove · commit 2a18ec79b68c · 2024-06-07T09:41:13.000-07:00
diff --git a/vm_insnhelper.h b/vm_insnhelper.h
@@ -271,7 +271,8 @@ vm_call_cacheable(const struct rb_callinfo *ci, const struct rb_callcache *cc)
 static inline bool
 vm_call_iseq_optimizable_p(const struct rb_callinfo *ci, const struct rb_callcache *cc)
 {
-    return !IS_ARGS_SPLAT(ci) && !IS_ARGS_KEYWORD(ci) && vm_call_cacheable(ci, cc);
+    return !IS_ARGS_SPLAT(ci) && !IS_ARGS_KEYWORD(ci) && ((vm_ci_flag(ci) & VM_CALL_FCALL) ||
+        METHOD_ENTRY_VISI(vm_cc_cme(cc)) != METHOD_VISI_PROTECTED);
 }
 
 #endif /* RUBY_INSNHELPER_H */

Original file line number	Diff line number	Diff line change
`@@ -271,7 +271,8 @@ vm_call_cacheable(const struct rb_callinfo ci, const struct rb_callcache cc)`
`271`	`271`	`static inline bool`
`272`	`272`	`vm_call_iseq_optimizable_p(const struct rb_callinfo ci, const struct rb_callcache cc)`
`273`	`273`	`{`
`274`		`- return !IS_ARGS_SPLAT(ci) && !IS_ARGS_KEYWORD(ci) && vm_call_cacheable(ci, cc);`
	`274`	`+ return !IS_ARGS_SPLAT(ci) && !IS_ARGS_KEYWORD(ci) && ((vm_ci_flag(ci) & VM_CALL_FCALL) \|\|`
	`275`	`+ METHOD_ENTRY_VISI(vm_cc_cme(cc)) != METHOD_VISI_PROTECTED);`
`275`	`276`	`}`
`276`	`277`
`277`	`278`	`#endif /* RUBY_INSNHELPER_H */`