Use ClearStateTestCase to ensure test consistency #51
php.yml
on: push
Annotations
12 errors and 3 warnings
|
Security checks
Process completed with exit code 1.
|
|
Quality control
Process completed with exit code 2.
|
|
UnusedIssueHandlerSuppression:
psalm-dev.xml#L0
/home/runner/work/simplesamlphp-module-sqlattribs/simplesamlphp-module-sqlattribs/psalm-dev.xml:0:0: UnusedIssueHandlerSuppression: Suppressed issue type "UnresolvableInclude" for /tests/bootstrap.php was not thrown. (see https://psalm.dev/326)
|
|
MissingOverrideAttribute:
tests/src/Auth/Process/AttributeFromSQLTest.php#L27
tests/src/Auth/Process/AttributeFromSQLTest.php:27:5: MissingOverrideAttribute: Method SimpleSAML\Test\Module\sqlattribs\Auth\Process\AttributeFromSQLTest::setup should have the "Override" attribute (see https://psalm.dev/358)
|
|
UnusedClass:
tests/src/Auth/Process/AttributeFromSQLTest.php#L11
tests/src/Auth/Process/AttributeFromSQLTest.php:11:13: UnusedClass: Class SimpleSAML\Test\Module\sqlattribs\Auth\Process\AttributeFromSQLTest is never used (see https://psalm.dev/075)
|
|
Quality control
Process completed with exit code 2.
|
|
RiskyTruthyFalsyComparison:
src/Auth/Process/AttributeFromSQL.php#L216
src/Auth/Process/AttributeFromSQL.php:216:17: RiskyTruthyFalsyComparison: Operand of type null|scalar contains type scalar, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
|
|
PossiblyNullArrayAccess:
src/Auth/Process/AttributeFromSQL.php#L206
src/Auth/Process/AttributeFromSQL.php:206:55: PossiblyNullArrayAccess: Cannot access array value on possibly null variable $attributes[$this->identifyingAttribute] of type mixed|null (see https://psalm.dev/079)
|
|
PossiblyUndefinedArrayOffset:
src/Auth/Process/AttributeFromSQL.php#L206
src/Auth/Process/AttributeFromSQL.php:206:55: PossiblyUndefinedArrayOffset: Possibly undefined array key $attributes[$this->identifyingAttribute] on array<array-key, mixed> (see https://psalm.dev/167)
|
|
UnusedVariable:
src/Auth/Process/AttributeFromSQL.php#L189
src/Auth/Process/AttributeFromSQL.php:189:13: UnusedVariable: $res is never referenced or the value is not used (see https://psalm.dev/077)
|
|
MissingOverrideAttribute:
src/Auth/Process/AttributeFromSQL.php#L160
src/Auth/Process/AttributeFromSQL.php:160:5: MissingOverrideAttribute: Method SimpleSAML\Module\sqlattribs\Auth\Process\AttributeFromSQL::process should have the "Override" attribute (see https://psalm.dev/358)
|
|
ClassMustBeFinal:
src/Auth/Process/AttributeFromSQL.php#L22
src/Auth/Process/AttributeFromSQL.php:22:7: ClassMustBeFinal: Class SimpleSAML\Module\sqlattribs\Auth\Process\AttributeFromSQL is never extended and is not part of the public API, and thus must be made final. (see https://psalm.dev/361)
|
|
PropertyNotSetInConstructor:
src/Auth/Process/AttributeFromSQL.php#L31
src/Auth/Process/AttributeFromSQL.php:31:21: PropertyNotSetInConstructor: Property SimpleSAML\Module\sqlattribs\Auth\Process\AttributeFromSQL::$password is not defined in constructor of SimpleSAML\Module\sqlattribs\Auth\Process\AttributeFromSQL or in any private or final methods called in the constructor (see https://psalm.dev/074)
|
|
PropertyNotSetInConstructor:
src/Auth/Process/AttributeFromSQL.php#L28
src/Auth/Process/AttributeFromSQL.php:28:21: PropertyNotSetInConstructor: Property SimpleSAML\Module\sqlattribs\Auth\Process\AttributeFromSQL::$username is not defined in constructor of SimpleSAML\Module\sqlattribs\Auth\Process\AttributeFromSQL or in any private or final methods called in the constructor (see https://psalm.dev/074)
|
|
UnusedClass:
src/Auth/Process/AttributeFromSQL.php#L22
src/Auth/Process/AttributeFromSQL.php:22:7: UnusedClass: Class SimpleSAML\Module\sqlattribs\Auth\Process\AttributeFromSQL is never used (see https://psalm.dev/075)
|