Skip to content

Commit ac70603

Browse files
committed
Moving error bound correction for QuantilesSketch to the implementation level since both users (TFT and TFDV) wired Compact.
PiperOrigin-RevId: 353692592
1 parent f492c2f commit ac70603

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

tensorflow_data_validation/statistics/generators/basic_stats_generator.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -991,11 +991,8 @@ def __init__(
991991
self._num_histogram_buckets = num_histogram_buckets
992992
self._num_quantiles_histogram_buckets = num_quantiles_histogram_buckets
993993

994-
# Epsilon is re-adjusted because we will call sketch.Compact() in
995-
# self.Compact(). More info here:
996-
# https://github.com/tensorflow/tfx-bsl/blob/master/tfx_bsl/cc/sketches/quantiles_sketch.h#L31
997994
self._make_quantiles_sketch_fn = lambda: sketches.QuantilesSketch( # pylint: disable=g-long-lambda
998-
eps=epsilon * 2 / 3.0,
995+
eps=epsilon,
999996
max_num_elements=1 << 32,
1000997
num_streams=1)
1001998

0 commit comments

Comments
 (0)