Skip to content

Fix missing value handling in Radon dataset. #11190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
May 7, 2026
+12 −8
Merged

Fix missing value handling in Radon dataset. #11190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions tensorflow_datasets/datasets/radon/radon_dataset_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,12 @@ def _split_generators(self, dl_manager):
'file_path_srrs2': urllib.parse.urljoin(BASE_URL, 'srrs2.dat'),
'file_path_cty': urllib.parse.urljoin(BASE_URL, 'cty.dat'),
})
return [
tfds.core.SplitGenerator(
name=tfds.Split.TRAIN,
gen_kwargs=paths,
return {
'train': self._generate_examples(
file_path_srrs2=paths['file_path_srrs2'],
file_path_cty=paths['file_path_cty'],
),
]
}

def _generate_examples(self, file_path_srrs2, file_path_cty):
"""Yields examples."""
Expand All @@ -127,9 +127,13 @@ def _generate_examples(self, file_path_srrs2, file_path_cty):
df = df.drop_duplicates(subset='idnum')
df.drop('fips', axis=1, inplace=True)

df['wave'].replace({' .': '-1'}, inplace=True)
df['rep'].replace({' .': '-1'}, inplace=True)
df['zip'].replace({' ': '-1'}, inplace=True)
# The raw data uses whitespace padding for missing values (e.g., " ." or
# " "). We cast to string, strip whitespace, and explicitly assign the
# result back to avoid pandas silent mutation failures with inplace dict
# replacements on object columns.
df['wave'] = df['wave'].astype(str).str.strip().replace('.', '-1')
df['rep'] = df['rep'].astype(str).str.strip().replace('.', '-1')
df['zip'] = df['zip'].astype(str).str.strip().replace('', '-1')

for i, (_, row) in enumerate(df.iterrows()):
radon_val = row.pop('activity')
Expand Down
Loading