Update 1.21.1 in version.py and RELEASE.md#69
Draft
vkarampudi wants to merge 8 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align protobuf dependency with compiled version and bump to 1.21.1
Description
This PR resolves a critical dependency mismatch introduced in the
v1.21.0release (Issue #68).In
v1.21.0, TFMD's build configuration (WORKSPACE) was upgraded to compile all C++ extensions againstprotobuf6.31.1. However,setup.pystill permitted older runtime versions of theprotobufpackage (e.g.,protobuf>=4.25.2). When users installed the library, pip could resolve to an olderprotobufruntime package, causing immediate startup and runtime crashes due to Protobuf C++ ABI/version mismatch checks (e.g.,google::protobuf::internal::VerifyVersion(...)aborting the process).To fix this, this PR:
protobufpackage dependency insetup.pytoprotobuf>=6.31.1,<7globally across all supported Python versions (>= 3.10).>=6.31.1: Since the C++ extensions in the wheels are compiled against6.31.1, the runtime package version must be at least6.31.1to pass Protobuf's strict runtime verification checks and avoid process crashes.<7: Adds an upper bound to prevent breaking ABI changes from future majorprotobufreleases.protobuf, making the configuration much cleaner.1.21.1intensorflow_metadata/version.py.1.21.1inRELEASE.mdfollowing the standard section structure.Changes
setup.py: Simplified and updated the globalprotobufrequirement toprotobuf>=6.31.1,<7.tensorflow_metadata/version.py: Bumped__version__from"1.21.0"to"1.21.1".RELEASE.md: Added release notes and standard sections forv1.21.1.Verification & Testing
python setup.py bdist_wheelbuilds and packages the library successfully with the new version and dependencies.pre-commit run --all-fileslocally; all linting, formatting (ruff), and sanity checks passed.pytest(python -m pytest), confirming that all tests (including dynamic proto loading) pass perfectly.pip installdry-run thattensorflow==2.21.0and our localtensorflow-metadata==1.21.1wheel resolve perfectly together without conflicts.