Simplify release scripts and update release instructions#1042
Open
mhucka wants to merge 5 commits intotensorflow:masterfrom
Open
Simplify release scripts and update release instructions#1042mhucka wants to merge 5 commits intotensorflow:masterfrom
mhucka wants to merge 5 commits intotensorflow:masterfrom
Conversation
Remove some features I never ended up using after all.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the release documentation and scripts for TensorFlow Quantum, specifically targeting TensorFlow 2.18 and streamlining the Docker-based build process. Key improvements include a new section in the README for managing dependencies via pip-tools and a refactored build_distribution.sh that uses more explicit Bazel toolchain configurations. The scripts were also simplified by removing dry-run and verbose options. Review feedback points out a minor typo and a missing backtick in the README, as well as a mismatch between the usage documentation and the actual flag implementation for Bazel options in the build script.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reflects what was used to produce the last release (0.7.6). There are two changes:
Update the instructions in
release/README.mdto add a step to regenerate therequirements.txtfile.Simplify the scripts
build_distribution.shandclean_distribution.shscripts based on experiences with producing the last two TFQ releases. I never ended up using some of the features anyway, and removing them lets us simplify the scripts noticeably. This is better for maintainability.