Adjust configure.sh to silence another set of protobuf compilation warnings#1043
Open
mhucka wants to merge 3 commits intotensorflow:masterfrom
Open
Adjust configure.sh to silence another set of protobuf compilation warnings#1043mhucka wants to merge 3 commits intotensorflow:masterfrom
configure.sh to silence another set of protobuf compilation warnings#1043mhucka wants to merge 3 commits intotensorflow:masterfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request modifies configure.sh to add the -Wno-stringop-overflow compiler flag for the protobuf dependency. A review comment correctly identifies that Bazel's per_file_copt option does not support comma-separated flags and will cause compilation errors; the reviewer suggests splitting the flags into multiple configuration lines.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compilation with gcc 15.2 on Debian Linux results in some warnings coming from the Protobuf library:
This is difficult to address directly, so this PR adds a narrowly-scoped silencing flag to the compilation arguments.