Skip to content

Commit 0743619

Browse files
authored
Skip linter issues. Add TODOs and ts-ignores that will be removed in … (#7045)
These comments temporarily suppress TypeScript warnings that will be fixed after upgrading to TypeScript 5.9.2 and should be removed at that point. Googlers: see http://b/471057679
1 parent b8afeb7 commit 0743619

2 files changed

Lines changed: 6 additions & 0 deletions

File tree

tensorboard/plugins/graph/tf_graph_common/common_test.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -568,6 +568,9 @@ async function slimGraphToHierarchy(
568568

569569
async function pbtxtToGraphDef(text: string): Promise<tf_graph_proto.GraphDef> {
570570
const encoder = new TextEncoder();
571+
// TODO: go/ts59upgrade - Remove this suppression after TS 5.9.2 upgrade
572+
// TS2345: Argument of type 'Uint8Array<ArrayBuffer>' is not assignable to parameter of type 'ArrayBuffer'.
573+
// @ts-ignore
571574
return tf_graph_parser.parseGraphPbTxt(encoder.encode(text));
572575
}
573576

tensorboard/webapp/widgets/line_chart_v2/lib/worker/compact_data_series_test.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,9 @@ describe('line_chart_v2/lib/compact_data_series', () => {
141141
length: 2,
142142
},
143143
],
144+
// TODO: go/ts59upgrade - Remove this suppression after TS 5.9.2 upgrade
145+
// TS2322: Type 'Float32Array<ArrayBuffer>' is not assignable to type 'ArrayBuffer'.
146+
// @ts-ignore
144147
flattenedSeries: new Float32Array([1, 2, 3]),
145148
};
146149

0 commit comments

Comments
 (0)