Commit 29f809f
authored
Remove runtime pkg_resources dependency in default and server_ingester (#7057)
## Motivation for features / changes
Fixes #7003.
`pkg_resources` is removed in newer setuptools, which can break
TensorBoard at import/runtime. This change removes runtime reliance on
`pkg_resources` in the two affected code paths.
## Technical description of changes
- Replaced dynamic plugin discovery in `tensorboard/default.py`:
- from `pkg_resources.iter_entry_points(...)`
- to `importlib.metadata.entry_points(...)` with compatibility handling
for different Python return shapes.
- Replaced version parsing in `tensorboard/data/server_ingester.py`:
- from `pkg_resources.parse_version(...)`
- to `packaging.version.parse(...)`.
- Updated related tests:
- `tensorboard/default_test.py` now patches `_iter_entry_points` and
uses `load()`-style fake entry points.
- `tensorboard/version_test.py` now validates PEP 440 behavior using
`packaging.version`.
- Updated Bazel deps to use `expect_packaging_installed` where
`packaging` is now required.
## Detailed steps to verify changes work correctly (as executed by you)
Executed locally in an isolated venv:
- `python -m py_compile tensorboard/default.py
tensorboard/default_test.py tensorboard/data/server_ingester.py
tensorboard/version_test.py`
- `PYTHONPATH=. python tensorboard/version_test.py` (passes)
Attempted but environment-limited locally:
- `bazel test //tensorboard:version_test //tensorboard:default_test
//tensorboard/data:server_ingester_test` (bazel not available in local
shell)
- Direct execution of `default_test.py` and `server_ingester_test.py`
without Bazel-generated artifacts hit local environment/import
constraints.
## Alternate designs / implementations considered (or N/A)
- N/A1 parent 3ad0c35 commit 29f809f
6 files changed
Lines changed: 39 additions & 71 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
309 | 309 | | |
310 | 310 | | |
311 | 311 | | |
312 | | - | |
313 | 312 | | |
314 | 313 | | |
315 | 314 | | |
| |||
347 | 346 | | |
348 | 347 | | |
349 | 348 | | |
350 | | - | |
351 | 349 | | |
352 | 350 | | |
353 | 351 | | |
| |||
367 | 365 | | |
368 | 366 | | |
369 | 367 | | |
370 | | - | |
| 368 | + | |
371 | 369 | | |
372 | 370 | | |
373 | 371 | | |
| |||
461 | 459 | | |
462 | 460 | | |
463 | 461 | | |
464 | | - | |
465 | | - | |
466 | | - | |
467 | | - | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
468 | 466 | | |
469 | 467 | | |
470 | 468 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
| 65 | + | |
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | 32 | | |
34 | 33 | | |
35 | 34 | | |
| |||
202 | 201 | | |
203 | 202 | | |
204 | 203 | | |
205 | | - | |
| 204 | + | |
206 | 205 | | |
207 | 206 | | |
208 | 207 | | |
| |||
231 | 230 | | |
232 | 231 | | |
233 | 232 | | |
234 | | - | |
235 | | - | |
236 | | - | |
| 233 | + | |
237 | 234 | | |
238 | 235 | | |
239 | 236 | | |
| |||
260 | 257 | | |
261 | 258 | | |
262 | 259 | | |
263 | | - | |
| 260 | + | |
264 | 261 | | |
265 | 262 | | |
266 | 263 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
28 | 27 | | |
29 | | - | |
30 | | - | |
| 28 | + | |
31 | 29 | | |
32 | 30 | | |
33 | 31 | | |
| |||
46 | 44 | | |
47 | 45 | | |
48 | 46 | | |
49 | | - | |
50 | 47 | | |
51 | 48 | | |
52 | 49 | | |
| |||
119 | 116 | | |
120 | 117 | | |
121 | 118 | | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
| 119 | + | |
| 120 | + | |
126 | 121 | | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
18 | 17 | | |
19 | 18 | | |
20 | | - | |
21 | | - | |
22 | 19 | | |
23 | | - | |
24 | 20 | | |
25 | 21 | | |
26 | 22 | | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
47 | 26 | | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
| 27 | + | |
| 28 | + | |
52 | 29 | | |
53 | 30 | | |
54 | 31 | | |
55 | | - | |
| 32 | + | |
56 | 33 | | |
57 | | - | |
| 34 | + | |
| 35 | + | |
58 | 36 | | |
59 | 37 | | |
60 | 38 | | |
61 | 39 | | |
62 | | - | |
| 40 | + | |
63 | 41 | | |
64 | 42 | | |
65 | 43 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
41 | 30 | | |
42 | 31 | | |
43 | 32 | | |
| |||
0 commit comments