Fix typescript linter errors (#7078)

## Motivation for features / changes
Fix linter errors in test files to keep the codebase compliant with
current TypeScript and tslint rules in internal build.
   
## Technical description of changes
                  
Cast `spyOn(store, 'dispatch') to jasmine.Spy` across 18 test files to
satisfy `NgRx` dispatch overload signatures. Updated `throwError to
factory form throwError(() => new Error(...))` per RxJS 7 requirements.
Added `tslint:disable-next-line:enforce-name-casing` suppressions for
snake_case keys that mirror backend API contracts.

Author: cdavalos7

tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/effects/debugger_effects_test.ts

@@ -401,9 +401,12 @@ describe('Debugger effects', () => {
     }).compileComponents();
 
     store = TestBed.inject<Store<State>>(Store) as MockStore<State>;
-    dispatchSpy = spyOn(store, 'dispatch').and.callFake((action: Action) => {
-      dispatchedActions.push(action);
-    });
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    dispatchSpy = (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake(
+      (action: Action) => {
+        dispatchedActions.push(action);
+      }
+    );
     store.overrideSelector(getActivePlugin, '');
   });
 
@@ -436,6 +439,7 @@ describe('Debugger effects', () => {
     begin: number,
     end: number,
     alertsResponse: AlertsResponse,
+    // tslint:disable-next-line:enforce-name-casing
     alert_type?: string
   ) {
     if (alert_type === undefined) {
@@ -1403,6 +1407,7 @@ describe('Debugger effects', () => {
       },
       begin: 0,
       end: 2,
+      // tslint:disable-next-line:enforce-name-casing
       alert_type: AlertType.INF_NAN_ALERT,
       per_type_alert_limit: 1000,
       alerts: [alert0, alert1],
@@ -1657,7 +1662,9 @@ describe('Debugger effects', () => {
         .withArgs(runId, fileIndex)
         .and.returnValue(
           of({
+            // tslint:disable-next-line:enforce-name-casing
             host_name: hostName,
+            // tslint:disable-next-line:enforce-name-casing
             file_path: filePath,
             lines,
           })

tensorboard/webapp/alert/alert_action_test.ts

@@ -59,7 +59,8 @@ describe('alert_effects', () => {
 
     store = TestBed.inject<Store<State>>(Store) as MockStore<State>;
     recordedActions = [];
-    spyOn(store, 'dispatch').and.callFake((action: Action) => {
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake((action: Action) => {
       recordedActions.push(action);
     });
   });

tensorboard/webapp/alert/views/alert_snackbar_test.ts

@@ -56,7 +56,8 @@ describe('alert snackbar', () => {
     }).compileComponents();
     store = TestBed.inject<Store<State>>(Store) as MockStore<State>;
     recordedActions = [];
-    spyOn(store, 'dispatch').and.callFake((action: Action) => {
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake((action: Action) => {
       recordedActions.push(action);
     });
     overlayContainer = TestBed.inject(OverlayContainer);

tensorboard/webapp/app_routing/effects/app_routing_effects_test.ts

@@ -243,7 +243,8 @@ describe('app_routing_effects', () => {
     store.overrideSelector(getRehydratedDeepLinks, []);
     actualActions = [];
 
-    spyOn(store, 'dispatch').and.callFake((action: Action) => {
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake((action: Action) => {
       actualActions.push(action);
     });
 

tensorboard/webapp/app_routing/views/router_link_test.ts

@@ -81,7 +81,8 @@ describe('router_link', () => {
       AppRootProvider
     ) as TestableAppRootProvider;
 
-    spyOn(store, 'dispatch').and.callFake((action: Action) => {
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake((action: Action) => {
       actualDispatches.push(action);
     });
   });

tensorboard/webapp/core/effects/core_effects_test.ts

@@ -111,7 +111,8 @@ describe('core_effects', () => {
     store = TestBed.inject<Store<State>>(Store) as MockStore<State>;
 
     recordedActions = [];
-    spyOn(store, 'dispatch').and.callFake((action: Action) => {
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake((action: Action) => {
       recordedActions.push(action);
     });
 

tensorboard/webapp/core/views/layout_test.ts

@@ -88,7 +88,8 @@ describe('layout test', () => {
 
     dispatchedActions = [];
     store = TestBed.inject<Store<State>>(Store) as MockStore<State>;
-    spyOn(store, 'dispatch').and.callFake((action: Action) => {
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake((action: Action) => {
       dispatchedActions.push(action);
     });
     store.overrideSelector(getSideBarWidthInPercent, 10);

tensorboard/webapp/header/dark_mode_toggle_test.ts

@@ -50,7 +50,8 @@ describe('dark mode toggle test', () => {
     store.overrideSelector(getEnableDarkModeOverride, null);
 
     dispatchedActions = [];
-    spyOn(store, 'dispatch').and.callFake((action: Action) => {
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake((action: Action) => {
       dispatchedActions.push(action);
     });
 

tensorboard/webapp/hparams/_redux/hparams_effects_test.ts

@@ -65,9 +65,12 @@ describe('hparams effects', () => {
     store = TestBed.inject<Store<State>>(Store) as MockStore<State>;
 
     actualActions = [];
-    dispatchSpy = spyOn(store, 'dispatch').and.callFake((action: Action) => {
-      actualActions.push(action);
-    });
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    dispatchSpy = (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake(
+      (action: Action) => {
+        actualActions.push(action);
+      }
+    );
 
     effects = TestBed.inject(HparamsEffects);
     dataSource = TestBed.inject(

tensorboard/webapp/metrics/effects/metrics_effects_test.ts

@@ -85,7 +85,8 @@ describe('metrics effects', () => {
     }).compileComponents();
 
     store = TestBed.inject<Store<State>>(Store) as MockStore<State>;
-    spyOn(store, 'dispatch').and.callFake((action: Action) => {
+    // Cast to jasmine.Spy for compatibility between NgRx dispatch signature overloads.
+    (spyOn(store, 'dispatch') as jasmine.Spy).and.callFake((action: Action) => {
       actualActions.push(action);
     });
     effects = TestBed.inject(MetricsEffects);