Angular Materials 18 - Remove redundancy#7127
Open
cdavalos7 wants to merge 8 commits into
Open
Conversation
… several transformations
# Conflicts: # tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/common/_lib.scss # tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/execution_data/execution_data_component.scss # tensorboard/plugins/debugger_v2/tf_debugger_v2_plugin/views/graph/graph_op_component.scss # tensorboard/webapp/feature_flag/views/feature_flag_dialog_component.scss # tensorboard/webapp/metrics/views/card_renderer/image_card_component.scss # tensorboard/webapp/metrics/views/card_renderer/scalar_card_component.scss # tensorboard/webapp/metrics/views/card_renderer/vis_linked_time_selection_warning_component.scss # tensorboard/webapp/metrics/views/main_view/filter_input_component.scss # tensorboard/webapp/metrics/views/main_view/main_view_component.scss # tensorboard/webapp/metrics/views/main_view/pinned_view_component.scss # tensorboard/webapp/metrics/views/metrics_container.scss # tensorboard/webapp/metrics/views/right_pane/scalar_column_editor/scalar_column_editor_component.scss # tensorboard/webapp/metrics/views/right_pane/settings_view_component.scss # tensorboard/webapp/notification_center/_views/notification_center_component.scss # tensorboard/webapp/runs/views/runs_table/runs_data_table.scss # tensorboard/webapp/runs/views/runs_table/runs_group_menu_button_component.scss # tensorboard/webapp/theme/_tb_palette.scss # tensorboard/webapp/theme/_tb_theme.template.scss # tensorboard/webapp/theme/_variable.scss # tensorboard/webapp/widgets/card_fob/card_fob_component.scss # tensorboard/webapp/widgets/content_wrapping_input/content_wrapping_input_component.scss # tensorboard/webapp/widgets/data_table/column_selector_component.scss # tensorboard/webapp/widgets/data_table/context_menu_component.scss # tensorboard/webapp/widgets/data_table/data_table_component.scss # tensorboard/webapp/widgets/data_table/filter_dialog_component.scss # tensorboard/webapp/widgets/data_table/header_cell_component.scss # tensorboard/webapp/widgets/dropdown/dropdown_component.scss # tensorboard/webapp/widgets/line_chart_v2/sub_view/line_chart_axis_view.scss
arcra
approved these changes
Jun 17, 2026
| * and $tb-warn | ||
| **********************************************************/ | ||
|
|
||
| // Angular Material theme definition. |
Member
There was a problem hiding this comment.
Ah, I was wondering why this file doesn't have the @use statements, and the comment on the next file clarified it.
Can you please add a comment here too, to make that clear when someone looks at this file?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
Technical description of changes
Because all three old names already pointed to the same module, the compiled CSS does not change at all — this is only a namespace/readability cleanup, with no change in behavior or look.