Fix build for cores without XT_NSAU, update in micro_allocations_info.cc - #3643
Open
unmeshna017 wants to merge 2 commits into
Open
Fix build for cores without XT_NSAU, update in micro_allocations_info.cc#3643unmeshna017 wants to merge 2 commits into
unmeshna017 wants to merge 2 commits into
Conversation
Guard XT_NSAU usage in msb_32/msb_64 with defined(XT_NSAU) so the build falls back to __builtin_clz on Xtensa cores that do not expose the nsau intrinsic (e.g. AE_HiFi4_LE5_FP_XC). Disable the xtensa_square_root.S assembly path (uses the unsupported nsau opcode) and its filter_bank_square_root.cc wrapper by renaming to .bak, matching the cad-audio port; the build then uses the reference C square-root implementation.
…e() function to ensure opcode read compatibility between the TFLite v3 and v3a schema versions.
unmeshna017
marked this pull request as ready for review
July 31, 2026 07:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nsauinstruction is always available, which breaks the build on HiFi4 cores where theXT_NSAUintrinsic is not defined.Adding @cad-audio and @joshih-cad for review