Skip to content

Fix OOB buffer index in GetFlatbufferTensorBuffer #3648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cloudymonstera wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

Fix OOB buffer index in GetFlatbufferTensorBuffer #3648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion tensorflow/lite/micro/micro_allocator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,17 @@ void* GetFlatbufferTensorBuffer(
// First see if there's any buffer information in the serialized tensor.
// TODO(b/170379532): Add better unit tests to validate flatbuffer values.
void* out_buffer = nullptr;
if (auto* buffer = (*buffers)[flatbuffer_tensor.buffer()]) {
// Reject out-of-range buffer indices. The compression-metadata path in this
// file already checks `buffer_index >= buffers->size()`; apply the same guard
// here so attacker-controlled tensor.buffer() cannot OOB-index the vector.
if (buffers == nullptr) {
return nullptr;
}
const uint32_t buffer_index = flatbuffer_tensor.buffer();
if (buffer_index >= buffers->size()) {
return nullptr;
}
if (auto* buffer = (*buffers)[buffer_index]) {
// If we've found a buffer, does it have any data?
if (auto* array = buffer->data()) {
// If it has any data, is the data size larger than zero?
Expand Down
Loading