JSON-LD Parser#426
Open
mcb5637 wants to merge 41 commits into
Open
Conversation
mcb5637
marked this pull request as ready for review
April 22, 2026 15:06
mcb5637
requested review from
liss-h and
nkaralis
and removed request for
liss-h
April 22, 2026 15:06
bigerl
added
the
not pobr breaking change
Merged
nkaralis
reviewed
May 13, 2026
nkaralis
left a comment
nkaralis
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the PR.
This is a first review focusing mostly on ParserTypes.
nkaralis
reviewed
May 21, 2026
nkaralis
left a comment
nkaralis
left a comment
Contributor
There was a problem hiding this comment.
Second round of questions and comments.
nkaralis
reviewed
Jun 9, 2026
nkaralis
left a comment
nkaralis
left a comment
Contributor
There was a problem hiding this comment.
Some more comments, mostly on ContextParser (parse_context_term is the only one left here).
| // 3 | ||
| if (parse_ctx != nullptr) { | ||
| auto i = parse_ctx->active_context.try_find_term(*value); | ||
| if (i != nullptr && i->parse_state != ParseState::Done && i != ignore_local) { |
Contributor
There was a problem hiding this comment.
in which case is the parse state done in this case?
Collaborator
Author
There was a problem hiding this comment.
Done => the term was parsed successfully.
This happens if one term in a context refers to another term in the context and the refered to term was parsed first.
I added comments to the enum type to explain what they represent.
| } | ||
| if (parse_ctx != nullptr) { | ||
| auto term = parse_ctx->active_context.try_find_term(pre); | ||
| if (term != nullptr && term->parse_state != ParseState::Done) { |
| } | ||
| for (auto v : a) { | ||
| switch (v.type()) { | ||
| case simdjson::ondemand::json_type::null: // 5.1 |
Contributor
There was a problem hiding this comment.
duplicate code (same code in the else if clause above). are both needed?
Collaborator
Author
There was a problem hiding this comment.
Both are needed, one is inside an array, the other in place of that array.
liss-h
force-pushed
the
feature/jsonld_parser
branch
from
July 22, 2026 07:30
0f29853 to
af3fd4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #424