JSON-LD Parser#426
Open
mcb5637 wants to merge 36 commits into
Open
Conversation
mcb5637
requested review from
liss-h and
nkaralis
and removed request for
liss-h
bigerl
added
the
not pobr breaking change
Merged
nkaralis
reviewed
May 13, 2026
Contributor
nkaralis
left a comment
nkaralis
left a comment
There was a problem hiding this comment.
Thank you for the PR.
This is a first review focusing mostly on ParserTypes.
| std::string base_iri; | ||
| std::optional<std::string> vocab = std::nullopt; | ||
| Context const *previous_context = nullptr; | ||
| LanguageMapping language = NotSet{}; |
Contributor
There was a problem hiding this comment.
is this needed in context and in every term definition?
Collaborator
Author
There was a problem hiding this comment.
nkaralis
reviewed
May 21, 2026
Contributor
nkaralis
left a comment
nkaralis
left a comment
There was a problem hiding this comment.
Second round of questions and comments.
| co_yield nonstd::make_unexpected(l.error()); | ||
| co_return; | ||
| } | ||
| if (p.active_subject.type != json_ld::IRIMappingType::None && p.active_property.type != json_ld::IRIMappingType::None) { |
Contributor
There was a problem hiding this comment.
can you provide an example that leads to this clause not being satisfied?
Collaborator
Author
There was a problem hiding this comment.
|
|
||
| simdjson::ondemand::object obj; | ||
| if (!map.expanded_from_no_map) { | ||
| obj = p.element; |
Collaborator
Author
There was a problem hiding this comment.
added a comment to the member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #424