fix: only run git if push or fail are enabled#152
Open
gmeligio wants to merge 1 commit into
Open
Conversation
Signed-off-by: Eligio Mariño <22875166+gmeligio@users.noreply.github.com>
gmeligio
marked this pull request as ready for review
April 5, 2025 12:05
|
+1 on this, it should not be stage by default escpecially when commits cant be verified |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
We can run the git commands only if the corresponding git features are enabled when calling the action. The background about this pull request is in the issue delegate git responsability to other github actions.
Related to #151
I have:
How has this code been tested
I haven't tested this change. I thought about how to test if git was disabled, that no git command was run, but it would involve adding an output to the action only for the sake of testing. Please let me know if you have any suggestions on how to test this change.