feat(datastream): add deletion_policy to google_datastream_private_connection#1292
Merged
Conversation
…nnection (#17120) [upstream:f13e512eb80b039e529fcfa2fa5a52266796c540] Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
merged commit 369d6a9
into
terraform-google-modules:master
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes hashicorp/terraform-provider-google#13054
Currently,
google_datastream_private_connectionalways sendsforce=truewhen deleting, which was introduced in #11394. This means child routes (managed outside Terraform) are always deleted without user control.This PR adds a
deletion_policyvirtual field (FORCE/DEFAULT) so users can control this behavior:FORCE(default): sendsforce=true, deleting child routes — preserves current behavior for backwards compatibilityDEFAULT: omits theforceparam, failing if child routes existChanges:
deletion_policyvirtual field toPrivateConnection.yamlwith defaultFORCEpre_deletetemplate to conditionally setforcebased ondeletion_policydeletion_policy = "FORCE"ignore_read_extrafordeletion_policyto existing examplesReference: https://googlecloudplatform.github.io/magic-modules/best-practices/deletion-behaviors/
Derived from GoogleCloudPlatform/magic-modules#17120