Add PSC connectivity support to Database Migration Service PrivateConnection#1312
Merged
Conversation
…nection (#17439) Co-authored-by: Anna Levadnaia <alevadnaia@google.com> [upstream:1f6c3df3ea67d2f1ba850b09462d8e57ecc7b2c9] Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
merged commit e5163a6
into
terraform-google-modules:master
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Private Service Connect (PSC) Interface connectivity to the
google_database_migration_service_private_connectionresource.Previously, only VPC Peering was supported for private connectivity. With this change, users can now choose between VPC Peering and PSC Interface configuration using a standard
oneofpattern.Key Changes:
PrivateConnection.yamlto include thepsc_interface_configblock and itsnetwork_attachmentproperty.exactly_one_ofconstraints to enforce that exactly one ofvpc_peering_configorpsc_interface_configis specified.Internal Tracking: b/510395527
Derived from GoogleCloudPlatform/magic-modules#17439