Skip to content

feat(hypercomputecluster): Add example for creating a cluster#941

Open
davide-zanon wants to merge 14 commits intoterraform-google-modules:mainfrom
davide-zanon:patch-7
Open

feat(hypercomputecluster): Add example for creating a cluster#941
davide-zanon wants to merge 14 commits intoterraform-google-modules:mainfrom
davide-zanon:patch-7

Conversation

@davide-zanon
Copy link
Copy Markdown
Contributor

@davide-zanon davide-zanon commented Apr 8, 2026 •
edited
Loading

This commit is an example for creating a cluster in Cluster Director by using Terraform.

Description

Fixes #499087255

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • [ X ] Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

  • [ X ] I have performed tests described in the Contributing guide:

    • [ X ] Tests pass: terraform apply
    • [ X ] Lint pass: terraform fmt check

Intended location

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

@davide-zanon
Add example for creating a cluster
63b4414 
This commit is an example for creating a cluster in Cluster Director by using Terraform.
@davide-zanon davide-zanon requested review from a team as code owners April 8, 2026 11:37
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Apr 8, 2026 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@iennae
Copy link
Copy Markdown
Contributor

iennae commented Apr 8, 2026

I haven't reviewed the code yet, but I've fixed the region tag as the proposed one was invalid.

hypercomputecluster_v1_clusterservice_cluster_create_slurm

@iennae
Copy link
Copy Markdown
Contributor

iennae commented Apr 8, 2026

/gcbrun

@iennae iennae mentioned this pull request Apr 8, 2026
Closed
2 tasks
rpgoog
rpgoog reviewed Apr 8, 2026
View reviewed changes
Comment thread cluster-director/main.tf Outdated
rpgoog
rpgoog reviewed Apr 8, 2026
View reviewed changes
Comment thread cluster-director/main.tf
rpgoog
rpgoog reviewed Apr 8, 2026
View reviewed changes
Comment thread cluster-director/main.tf
davide-zanon and others added 2 commits April 8, 2026 23:35
@davide-zanon @rpgoog
Update cluster-director/main.tf
1f0049d 
Co-authored-by: rpgoog <266194224+rpgoog@users.noreply.github.com>
@davide-zanon @rpgoog
Update cluster-director/main.tf
e054af9 
Co-authored-by: rpgoog <266194224+rpgoog@users.noreply.github.com>
@davide-zanon
Copy link
Copy Markdown
Contributor Author

davide-zanon commented Apr 9, 2026

@rpgoog, @iennae, it seems that the integration test is failing. As the reservation uses sample values, there's no way to test it. Is there a way to deactivate the test?

@rpgoog
Copy link
Copy Markdown

rpgoog commented Apr 9, 2026

@davide-zanon

  1. there is a comment unresolved due to which one of the check is failing. The region tag at the beginning of the file needs to be changed too.

  2. Yes, there is a way to deactivate the test - a test.yaml file with skip: true can be added to skip the test. Details in b/499087255

@iennae iennae changed the title Add example for creating a cluster feat(hypercomputecluster): Add example for creating a cluster Apr 9, 2026
@iennae
Copy link
Copy Markdown
Contributor

iennae commented Apr 9, 2026

The top-level directory needs to be changed to /hypercomputecluster/ as mentioned in the merged CODEOWNERS update. it needs to match the SDK.

@iennae
Copy link
Copy Markdown
Contributor

iennae commented Apr 9, 2026

/gcbrun

@iennae
Copy link
Copy Markdown
Contributor

iennae commented Apr 9, 2026

/gcbrun

@davide-zanon davide-zanon requested a review from a team as a code owner April 9, 2026 20:19
@davide-zanon
Copy link
Copy Markdown
Contributor Author

davide-zanon commented Apr 9, 2026

The top-level directory needs to be changed to /hypercomputecluster/ as mentioned in the merged CODEOWNERS update. it needs to match the SDK.

Thanks for your input on this! I renamed the directory.

@davide-zanon
Copy link
Copy Markdown
Contributor Author

davide-zanon commented Apr 9, 2026

@rpgoog, I've added a test.yaml file to the repository as you recommended. You mention that the region has to be changed. Could you please show me how? Thanks again for your help with this!

@rpgoog
Copy link
Copy Markdown

rpgoog commented Apr 9, 2026

@rpgoog, I've added a test.yaml file to the repository as you recommended. You mention that the region has to be changed. Could you please show me how? Thanks again for your help with this!

It has been fixed.

@rpgoog
Copy link
Copy Markdown

rpgoog commented Apr 9, 2026

/gcbrun

1 similar comment
@iennae
Copy link
Copy Markdown
Contributor

iennae commented Apr 10, 2026

/gcbrun

@davide-zanon
Update main.tf
31dadc7 
Fixed whitespace issue.
@davide-zanon
Copy link
Copy Markdown
Contributor Author

davide-zanon commented Apr 11, 2026

/gcbrun

@davide-zanon
Update main.tf
2605569 
Fixing a whitespace issue.
@davide-zanon
Update main.tf
53f2c1b 
Fixed the start and end tags.
@davide-zanon
Update test.yaml
a8acd81 
Fixed the test using the new tags.
@davide-zanon
Copy link
Copy Markdown
Contributor Author

davide-zanon commented Apr 15, 2026

/gcbrun

@davide-zanon
Copy link
Copy Markdown
Contributor Author

davide-zanon commented Apr 15, 2026

@rpgoog, could you please run /gcbrun once more? I think I fixed all the issues that you have previously flagged. Thanks again for your help!

@glasnt
Copy link
Copy Markdown
Contributor

glasnt commented Apr 19, 2026

/gcbrun

@glasnt glasnt requested a review from iennae April 21, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iennae iennae Awaiting requested review from iennae

1 more reviewer

@rpgoog rpgoog rpgoog left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@davide-zanon @iennae @rpgoog @glasnt