Skip to content

Align Terraform connector samples with UI defaults #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lamdaham wants to merge 4 commits into
base: main
Choose a base branch
from
+14 −13
Open

Align Terraform connector samples with UI defaults #959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6175228
fix: enable streaming pull in Pub/Sub source connector configuration …
lamdaham Jun 29, 2026
ea8f8f8
fix: update Kafka connector converters from StringConverter to ByteAr…
lamdaham Jun 29, 2026
bdd284a
fix: update MirrorMaker 2 bootstrap server addresses to use dynamic M…
lamdaham Jun 30, 2026
686b770
fix: update dns_domain_names to use dynamic cluster and project refer…
lamdaham Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions managedkafka/managedkafka_create_connector_mirrormaker2_source/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ resource "google_managed_kafka_connect_cluster" "default" {
# "GMK_CLUSTER_ID.REGION.managedkafka.PROJECT_ID.cloud.goog.*"
# Please note that we do NOT need to add the DNS name of the primary Kafka cluster to the
# `dns_domain_names` list, as our Connect cluster configures that automatically.
dns_domain_names = ["DNS_DOMAIN_NAME"]
dns_domain_names = ["${google_managed_kafka_cluster.source.cluster_id}.${google_managed_kafka_cluster.source.location}.managedkafka.${data.google_project.default.project_id}.cloud.goog."]
}
}
}
Expand Down Expand Up @@ -118,8 +118,8 @@ resource "google_managed_kafka_connector" "default" {
"topics" = ".*" # Replicate all topics from the source
# The value for bootstrap.servers is a comma-separated list of hostname:port pairs
# for one or more Kafka brokers in the source/target cluster.
"source.cluster.bootstrap.servers" = "source_cluster_dns"
"target.cluster.bootstrap.servers" = "target_cluster_dns"
"source.cluster.bootstrap.servers" = "bootstrap.${google_managed_kafka_cluster.source.cluster_id}.${google_managed_kafka_cluster.source.location}.managedkafka.${data.google_project.default.project_id}.cloud.goog:9092"
"target.cluster.bootstrap.servers" = "bootstrap.${google_managed_kafka_cluster.target.cluster_id}.${google_managed_kafka_cluster.target.location}.managedkafka.${data.google_project.default.project_id}.cloud.goog:9092"
# You can define an exclusion policy for topics as follows:
# To exclude internal MirrorMaker 2 topics, internal topics and replicated topics,.
"topics.exclude" = "mm2.*\\.internal,.*\\.replica,__.*"
Expand Down
4 changes: 2 additions & 2 deletions managedkafka/managedkafka_create_connector_pubsub_sink/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ resource "google_managed_kafka_connector" "example-pubsub-sink-connector" {
"topics" = "TOPIC_NAME"
"cps.topic" = "CPS_TOPIC_NAME"
"cps.project" = "CPS_PROJECT_NAME"
"value.converter" = "org.apache.kafka.connect.storage.StringConverter"
"key.converter" = "org.apache.kafka.connect.storage.StringConverter"
"value.converter" = "org.apache.kafka.connect.converters.ByteArrayConverter"
"key.converter" = "org.apache.kafka.connect.converters.ByteArrayConverter"
}

provider = google-beta
Expand Down
17 changes: 9 additions & 8 deletions managedkafka/managedkafka_create_connector_pubsub_source/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,14 +79,15 @@ resource "google_managed_kafka_connector" "example-pubsub-source-connector" {
location = "us-central1"

configs = {
"connector.class" = "com.google.pubsub.kafka.source.CloudPubSubSourceConnector"
"name" = "my-pubsub-source-connector"
"tasks.max" = "3"
"kafka.topic" = "GMK_TOPIC_ID"
"cps.subscription" = "CPS_SUBSCRIPTION_ID"
"cps.project" = data.google_project.default.project_id
"value.converter" = "org.apache.kafka.connect.converters.ByteArrayConverter"
"key.converter" = "org.apache.kafka.connect.storage.StringConverter"
"connector.class" = "com.google.pubsub.kafka.source.CloudPubSubSourceConnector"
"name" = "my-pubsub-source-connector"
"tasks.max" = "3"
"kafka.topic" = "GMK_TOPIC_ID"
"cps.subscription" = "CPS_SUBSCRIPTION_ID"
"cps.project" = data.google_project.default.project_id
"cps.streamingPull.enable" = "true"
"value.converter" = "org.apache.kafka.connect.converters.ByteArrayConverter"
"key.converter" = "org.apache.kafka.connect.storage.StringConverter"
}

provider = google-beta
Expand Down