fix: move deprecated to versioned resources#2521
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
apeabody
left a comment
There was a problem hiding this comment.
Thanks for the contribution @HarisDotParis!
Please run make docker_generate_docs and add to your change.
4795c74 to
93f1407
Compare
|
/gcbrun |
apeabody
left a comment
There was a problem hiding this comment.
Thanks for the contribution @HarisDotParis
From the lint:
terraform_validate ./test/fixtures/workload_identity
╷
│ Error: Unsupported argument
│
│ on ../../../examples/workload_identity/main.tf line 65, in module "workload_identity":
│ 65: network = var.network
│
│ An argument named "network" is not expected here.
╵
╷
│ Error: Unsupported argument
│
│ on ../../../examples/workload_identity/main.tf line 66, in module "workload_identity":
│ 66: subnetwork = var.subnetwork
│
│ An argument named "subnetwork" is not expected here.
╵
╷
│ Error: Unsupported argument
│
│ on ../../../examples/workload_identity/main.tf line 67, in module "workload_identity":
│ 67: ip_range_pods = var.ip_range_pods
│
│ An argument named "ip_range_pods" is not expected here.
| network = var.network | ||
| subnetwork = var.subnetwork | ||
| ip_range_pods = var.ip_range_pods |
There was a problem hiding this comment.
I think those are irrelevant here, but the deleted ones should remain.
| network = var.network | ||
| subnetwork = var.subnetwork | ||
| ip_range_pods = var.ip_range_pods |
There was a problem hiding this comment.
Same here, irrelevant fields, but use_existing_gcp_sa should be kept
|
x-ref kubernetes provider bump: #2501 |
|
this PR will handle service accounts: #2560 |
examples/, then its resource type is only renamed, but there is no corresponding moved block as that is only exemplary codeexamples/workload_identity/main.tfhas been updated to be valid and syntactically correct