fix: Change resource type to kubernetes_config_map_v1

[maxxieb]

Fix deprecation warning when planning against provider v7.15.0

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @maxxieb, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a deprecation warning by updating a Kubernetes resource definition to its current version. The change ensures compatibility with the specified provider version, preventing potential issues during infrastructure planning and maintaining the stability of the configuration.

Highlights

• Kubernetes Resource Update: The kubernetes_config_map resource type has been updated to kubernetes_config_map_v1 in modules/private-cluster/masq.tf.
• Deprecation Warning Fix: This change resolves a deprecation warning encountered when planning against provider v7.15.0.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly updates the kubernetes_config_map resource to kubernetes_config_map_v1 to address a deprecation warning. However, the change has been applied to an auto-generated file instead of its source template. To make the fix permanent, the corresponding template file, autogen/main/masq.tf.tmpl, must also be updated.

[apeabody]

/gcbrun

[apeabody]

Thanks for the contribution @maxxieb!

Please run make build and add the changes to this PR.

[maxxieb]

Please run make build and add the changes to this PR.

@apeabody done

[apeabody]

/gcbrun

[m0ps]

This isn't the only 1 affected resource. Plus, if it is implemented as proposed, it will trigger resource recreation (delete+create). I suppose the solution proposed in #2521 (which includes move) is more comprehensive and gentle, as it avoids recreating the old resource by instead moving it to the new one.

P.S. haven't tried it personally, but from the docs it sounds like it's just a "cosmetic" change, so move should work pretty well here.

[apeabody]

This isn't the only 1 affected resource. Plus, if it is implemented as proposed, it will trigger resource recreation (delete+create). I suppose the solution proposed in #2521 (which includes move) is more comprehensive and gentle, as it avoids recreating the old resource by instead moving it to the new one.

P.S. haven't tried it personally, but from the docs it sounds like it's just a "cosmetic" change, so move should work pretty well here.

Thanks @m0ps!

[apeabody]

Thanks for the contribution @maxxieb!

Can you please migrate all relevant types:

• kubernetes_service
• kubernetes_service_account
• kubernetes_config_map (already in this change)
• kubernetes_pod

And also include move blocks so this can be a minor change.

Thanks!

[maxxieb]

Hi @apeabody

No problem!

I should be able to find some some time to make the requested changes by the EOW

[sethmccombs]

Hey @maxxieb - do you have time to tackle this? If not, happy to pick this up, saw the deprecation warning today and scrolled through issues and PRs before I opened my own

[jullianow]

Is there anything we can do to continue this?