fix(vpc): avoid deprecated numeric_id warning in network output#707
Open
bruno561 wants to merge 2 commits into
Open
fix(vpc): avoid deprecated numeric_id warning in network output#707bruno561 wants to merge 2 commits into
bruno561 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #706 by removing the deprecation warning triggered by the network output in the VPC submodule.
Previously, the output returned the full google_compute_network.network resource object, which surfaces a deprecated provider attribute (numeric_id) during validation.
This change replaces that with an explicit object of selected stable attributes.
Changes
modules/vpc/outputs.tf:output "network"value from raw resource object to a selected attribute map.network_idfromgoogle_compute_network.network.network_id.numeric_idas a compatibility alias mapped tonetwork_id.modules/vpc/README.mdoutput description fornetworkto reflect the new shape.Why this approach
network.numeric_id.Validation
terraform init(inmodules/vpc)terraform validate(inmodules/vpc) -> SuccessCloses #706