refactor: remove unused VPC resources from apps example (#322)

* refactor: Remove unused VPC resources from apps example

* SKIP UPGRADE TEST

---------

Co-authored-by: Khuzaima-Shakeel <Khuzaima.Shakeel@ibm.com>

Author: Khuzaima05

examples/apps/README.md

@@ -13,8 +13,7 @@ An end-to-end apps example that will provision the following:
 - Code Engine TLS Secret
 - Code Engine Domain Mapping
 - Secrets Manager Resources (Public Engine, Group, Public Certificate)
-- A Virtual Private Cloud (VPC).
-- A context-based restriction (CBR) rule to allow Code Engine to be accessible from VPC and Schematics.
+- A context-based restriction (CBR) rule to allow Code Engine to be accessible from Schematics.
 
 <!-- BEGIN SCHEMATICS DEPLOY TIP HOOK -->
 :information_source: Ctrl/Cmd+Click or right-click on the Schematics deploy button to open in a new tab

examples/apps/main.tf

@@ -104,39 +104,10 @@ data "ibm_sm_public_certificate" "public_certificate" {
 data "ibm_iam_account_settings" "iam_account_settings" {
 }
 
-##############################################################################
-# VPC
-##############################################################################
-resource "ibm_is_vpc" "example_vpc" {
-  name           = "${var.prefix}-vpc"
-  resource_group = module.resource_group.resource_group_id
-  tags           = var.resource_tags
-}
-
-resource "ibm_is_subnet" "testacc_subnet" {
-  name                     = "${var.prefix}-subnet"
-  vpc                      = ibm_is_vpc.example_vpc.id
-  zone                     = "${var.region}-1"
-  total_ipv4_address_count = 256
-  resource_group           = module.resource_group.resource_group_id
-}
-
 ##############################################################################
 # Create CBR Zone
 ##############################################################################
 
-module "cbr_vpc_zone" {
-  source           = "terraform-ibm-modules/cbr/ibm//modules/cbr-zone-module"
-  version          = "1.36.0"
-  name             = "${var.prefix}-VPC-network-zone"
-  zone_description = "CBR Network zone representing VPC"
-  account_id       = data.ibm_iam_account_settings.iam_account_settings.account_id
-  addresses = [{
-    type  = "vpc",
-    value = ibm_is_vpc.example_vpc.crn
-  }]
-}
-
 module "cbr_zone_schematics" {
   source           = "terraform-ibm-modules/cbr/ibm//modules/cbr-zone-module"
   version          = "1.36.0"
@@ -168,21 +139,11 @@ module "code_engine" {
       account_id       = data.ibm_iam_account_settings.iam_account_settings.account_id
       rule_contexts = [{
         attributes = [
-          {
-            "name" : "endpointType",
-            "value" : "public"
-          },
           {
             name  = "networkZoneId"
-            value = module.cbr_vpc_zone.zone_id
-        }]
-        },
-        {
-          attributes = [
-            {
-              name  = "networkZoneId"
-              value = module.cbr_zone_schematics.zone_id
-          }]
+            value = module.cbr_zone_schematics.zone_id
+          }
+        ]
       }]
       operations = [{
         api_types = [{

examples/apps/variables.tf

@@ -26,13 +26,6 @@ variable "resource_group" {
   default     = null
 }
 
-variable "resource_tags" {
-  type        = list(string)
-  description = "Optional list of tags to be added to created resources"
-  default     = []
-}
-
-
 ##############################################################
 # Secret Manager
 ##############################################################