test: remove desktop MCP integration tests from terraphim_mcp_server

Author: Terraphim CI

crates/terraphim_mcp_server/tests/desktop_mcp_integration.rs

@@ -1,7 +1,6 @@
 use anyhow::Result;
 use rmcp::{model::CallToolRequestParam, service::ServiceExt, transport::TokioChildProcess};
 use serial_test::serial;
-use std::path::PathBuf;
 use terraphim_config::{
     ConfigBuilder, Haystack, KnowledgeGraph, KnowledgeGraphLocal, Role, ServiceType,
 };
@@ -15,36 +14,6 @@ use terraphim_automata::builder::{Logseq, ThesaurusBuilder};
 use terraphim_persistence::DeviceStorage;
 use terraphim_persistence::Persistable;
 
-fn resolve_desktop_binary() -> Result<Option<PathBuf>> {
-    if let Ok(path) = std::env::var("TERRAPHIM_DESKTOP_BINARY") {
-        let path = PathBuf::from(path);
-        if path.exists() {
-            return Ok(Some(path));
-        }
-        anyhow::bail!(
-            "TERRAPHIM_DESKTOP_BINARY is set but file does not exist: {}",
-            path.display()
-        );
-    }
-
-    let current_dir = std::env::current_dir()?;
-    let project_root = current_dir
-        .parent()
-        .and_then(|p| p.parent())
-        .ok_or_else(|| anyhow::anyhow!("Cannot find workspace root"))?;
-    let binary_name = if cfg!(target_os = "windows") {
-        "terraphim-ai-desktop.exe"
-    } else {
-        "terraphim-ai-desktop"
-    };
-    let desktop_binary = project_root.join("target").join("debug").join(binary_name);
-    if desktop_binary.exists() {
-        Ok(Some(desktop_binary))
-    } else {
-        Ok(None)
-    }
-}
-
 /// Create a configuration with the correct "Terraphim Engineer" role
 /// that uses local KG files and builds thesaurus from local markdown files
 async fn create_terraphim_engineer_config() -> Result<String> {
@@ -296,80 +265,6 @@ async fn test_mcp_server_terraphim_engineer_search() -> Result<()> {
     Ok(())
 }
 
-/// Test desktop CLI integration with MCP server
-#[tokio::test]
-#[serial]
-async fn test_desktop_cli_mcp_search() -> Result<()> {
-    // Use memory-only persistence to avoid database conflicts between tests
-    set_env_var("TERRAPHIM_PROFILE_MEMORY_TYPE", "memory");
-
-    println!("🖥️ Testing desktop CLI with MCP server...");
-
-    let Some(desktop_binary) = resolve_desktop_binary()? else {
-        eprintln!(
-            "Skipping desktop CLI MCP test: set TERRAPHIM_DESKTOP_BINARY to external terraphim-ai-desktop binary"
-        );
-        return Ok(());
-    };
-
-    // Test that desktop binary can run in MCP server mode
-    let mut cmd = Command::new(&desktop_binary);
-    cmd.arg("mcp-server")
-        .stdin(std::process::Stdio::piped())
-        .stdout(std::process::Stdio::piped())
-        .stderr(std::process::Stdio::piped());
-
-    let transport = TokioChildProcess::new(cmd)?;
-    let service = ().serve(transport).await?;
-
-    println!("✅ Desktop CLI running in MCP server mode");
-
-    // Update config and test search - same as above
-    let config_json = create_terraphim_engineer_config().await?;
-
-    let config_result = service
-        .call_tool(CallToolRequestParam {
-            name: "update_config_tool".into(),
-            arguments: serde_json::json!({
-                "config_str": config_json
-            })
-            .as_object()
-            .cloned(),
-        })
-        .await?;
-
-    assert!(
-        !config_result.is_error.unwrap_or(false),
-        "Config update should succeed"
-    );
-
-    // Test search
-    let search_result = service
-        .call_tool(CallToolRequestParam {
-            name: "search".into(),
-            arguments: serde_json::json!({
-                "query": "terraphim-graph",
-                "limit": 3
-            })
-            .as_object()
-            .cloned(),
-        })
-        .await?;
-
-    assert!(
-        !search_result.is_error.unwrap_or(false),
-        "Search should succeed"
-    );
-
-    let result_count = search_result.content.len().saturating_sub(1);
-    assert!(result_count > 0, "Should find terraphim-graph documents");
-
-    service.cancel().await?;
-    println!("✅ Desktop CLI MCP server working correctly");
-
-    Ok(())
-}
-
 /// Test role switching via config API before search
 #[tokio::test]
 #[serial]

crates/terraphim_mcp_server/tests/mcp_rolegraph_validation_test.rs

@@ -1,44 +1,9 @@
 use anyhow::Result;
 use rmcp::{model::CallToolRequestParam, service::ServiceExt, transport::TokioChildProcess};
 use serde_json::json;
-use std::path::PathBuf;
 use std::process::Stdio;
 use tokio::process::Command;
 
-fn resolve_desktop_binary() -> Result<Option<PathBuf>> {
-    if let Ok(path) = std::env::var("TERRAPHIM_DESKTOP_BINARY") {
-        let path = PathBuf::from(path);
-        if path.exists() {
-            return Ok(Some(path));
-        }
-        anyhow::bail!(
-            "TERRAPHIM_DESKTOP_BINARY is set but file does not exist: {}",
-            path.display()
-        );
-    }
-
-    let crate_dir = std::env::current_dir()?;
-    let binary_name = if cfg!(target_os = "windows") {
-        "terraphim-ai-desktop.exe"
-    } else {
-        "terraphim-ai-desktop"
-    };
-
-    let workspace_root = crate_dir
-        .parent()
-        .and_then(|p| p.parent())
-        .ok_or_else(|| anyhow::anyhow!("Cannot find workspace root"))?;
-    let candidate = workspace_root
-        .join("target")
-        .join("debug")
-        .join(binary_name);
-    if candidate.exists() {
-        Ok(Some(candidate))
-    } else {
-        Ok(None)
-    }
-}
-
 /// Test that MCP server properly separates logs from JSON-RPC responses
 #[tokio::test]
 async fn test_mcp_log_separation_and_tools() -> Result<()> {
@@ -171,45 +136,6 @@ async fn test_mcp_log_separation_and_tools() -> Result<()> {
     Ok(())
 }
 
-/// Test that desktop MCP integration works without --ignored flag
-#[tokio::test]
-async fn test_desktop_mcp_integration_fixed() -> Result<()> {
-    println!("🖥️ Testing desktop MCP integration");
-    let Some(desktop_binary) = resolve_desktop_binary()? else {
-        eprintln!(
-            "Skipping desktop MCP integration test: set TERRAPHIM_DESKTOP_BINARY to external terraphim-ai-desktop binary"
-        );
-        return Ok(());
-    };
-
-    println!("✅ Desktop binary available at: {:?}", desktop_binary);
-
-    // Test desktop in MCP server mode
-    let mut cmd = Command::new(desktop_binary);
-    cmd.arg("mcp-server")
-        .stdin(Stdio::piped())
-        .stdout(Stdio::piped())
-        .stderr(Stdio::piped());
-
-    let transport = TokioChildProcess::new(cmd)?;
-    let service = ().serve(transport).await?;
-
-    println!("✅ Desktop MCP server connected: {:?}", service.peer_info());
-
-    // Basic functionality test
-    let tools = service.list_tools(Default::default()).await?;
-    assert!(
-        !tools.tools.is_empty(),
-        "Desktop MCP server should expose tools"
-    );
-
-    println!(
-        "✅ Desktop MCP integration test passed with {} tools",
-        tools.tools.len()
-    );
-    Ok(())
-}
-
 /// Test MCP server with role switching and configuration updates
 #[tokio::test]
 async fn test_mcp_role_configuration() -> Result<()> {