fix: apply PR #208 review comments for lifecycle and configuration issues

Author: AlexMikhalev

.clippy.toml

@@ -1,5 +1,5 @@
 # Optimized clippy configuration for faster CI builds
-msrv = "1.70.0"
+msrv = "1.82.0"
 avoid-breaking-exported-api = false
 allow-mixed-uninlined-format-args = true
 allow-unwrap-in-tests = true
@@ -8,7 +8,6 @@ allow-dbg-in-tests = true
 too-many-arguments-threshold = 12
 type-complexity-threshold = 250
 cognitive-complexity-threshold = 30
-unreadable-literal-threshold = 100
 # Reduce false positives and focus on important issues
 disallowed-names = []
 doc-valid-idents = ["Cli", "TODO", "FIXME", "XXX", "WIP", "WARN", "NOTE", "INFO", "DEBUG"]
@@ -17,12 +16,4 @@ max-trait-bounds = 3
 max-fn-params-bools = 3
 enum-variant-name-threshold = 50
 # Allow certain patterns for faster development
-single-char-binding-names-threshold = 4
-# Skip expensive lints in CI
-cargo-ignore = [
-    "clippy::nursery/",
-    "clippy::pedantic/",
-    "clippy::cargo/",
-    "clippy::complexity/",
-    "clippy::perf/",
-]
+single-char-binding-names-threshold = 4

crates/terraphim_agent_application/src/application.rs

@@ -47,8 +47,8 @@ pub struct TerraphimAgentApplication {
     state: Arc<RwLock<ApplicationState>>,
     /// Configuration manager
     config_manager: Arc<ConfigurationManager>,
-    /// Lifecycle manager
-    lifecycle_manager: Arc<LifecycleManager>,
+     /// Lifecycle manager
+     lifecycle_manager: Arc<RwLock<LifecycleManager>>,
     /// Deployment manager
     deployment_manager: Arc<DeploymentManager>,
     /// Hot reload manager
@@ -262,7 +262,7 @@ impl TerraphimAgentApplication {
         let config_manager = Arc::new(ConfigurationManager::new(config_path).await?);
         let config = config_manager.get_config().await;
 
-        let lifecycle_manager = Arc::new(LifecycleManager::new(config.clone()).await?);
+        let lifecycle_manager = LifecycleManager::new(config.clone()).await?;
         let deployment_manager = Arc::new(DeploymentManager::new(config.clone()).await?);
         let hot_reload_manager = Arc::new(HotReloadManager::new(config.clone()).await?);
         let diagnostics_manager = Arc::new(DiagnosticsManager::new(config.clone()).await?);
@@ -272,7 +272,7 @@ impl TerraphimAgentApplication {
         Ok(Self {
             state: Arc::new(RwLock::new(ApplicationState::default())),
             config_manager,
-            lifecycle_manager,
+             lifecycle_manager: Arc::new(RwLock::new(lifecycle_manager)),
             deployment_manager,
             hot_reload_manager,
             diagnostics_manager,
@@ -483,7 +483,7 @@ impl Application for TerraphimAgentApplication {
         self.start_message_handler().await?;
 
         // Start lifecycle manager
-        self.lifecycle_manager.start().await?;
+        self.lifecycle_manager.write().await.start().await?;
 
         // Start deployment manager
         self.deployment_manager.start().await?;
@@ -568,7 +568,7 @@ impl Application for TerraphimAgentApplication {
             warn!("Error stopping deployment manager: {}", e);
         }
 
-        if let Err(e) = self.lifecycle_manager.stop().await {
+        if let Err(e) = self.lifecycle_manager.write().await.stop().await {
             warn!("Error stopping lifecycle manager: {}", e);
         }
 

crates/terraphim_agent_application/src/config.rs

@@ -262,19 +262,19 @@ impl Default for ApplicationConfig {
     }
 }
 
-/// Configuration manager with hot reloading capabilities
-pub struct ConfigurationManager {
-    /// Current configuration
-    config: Arc<RwLock<ApplicationConfig>>,
-    /// Configuration file path
-    config_path: PathBuf,
-    /// File watcher for hot reloading
-    _watcher: Option<RecommendedWatcher>,
-    /// Configuration change notifications
-    change_tx: mpsc::UnboundedSender<ConfigurationChange>,
-    /// Configuration change receiver
-    change_rx: Arc<RwLock<Option<mpsc::UnboundedReceiver<ConfigurationChange>>>>,
-}
+ /// Configuration manager with hot reloading capabilities
+ pub struct ConfigurationManager {
+     /// Current configuration
+     config: Arc<RwLock<ApplicationConfig>>,
+     /// Configuration file path
+     config_path: PathBuf,
+     /// File watcher for hot reloading
+     _watcher: Option<RecommendedWatcher>,
+     /// Configuration change notifications
+     change_tx: mpsc::UnboundedSender<ConfigurationChange>,
+     /// Configuration change receiver
+     change_rx: Arc<RwLock<Option<mpsc::UnboundedReceiver<ConfigurationChange>>>>,
+ }
 
 /// Configuration change notification
 #[derive(Debug, Clone)]
@@ -322,21 +322,20 @@ impl ConfigurationManager {
         })
     }
 
-    /// Load configuration from file
-    async fn load_config(config_path: &Path) -> ApplicationResult<ApplicationConfig> {
-        let mut config_builder = Config::builder()
-            .add_source(File::from(config_path).required(false))
-            .add_source(Environment::with_prefix("TERRAPHIM"));
-
-        // Add default configuration
-        let default_config = ApplicationConfig::default();
-        let default_toml = toml::to_string(&default_config)
-            .map_err(|e| ApplicationError::ConfigurationError(e.to_string()))?;
-
-        config_builder = config_builder.add_source(config::File::from_str(
-            &default_toml,
-            config::FileFormat::Toml,
-        ));
+     /// Load configuration from file
+     async fn load_config(config_path: &Path) -> ApplicationResult<ApplicationConfig> {
+         // Add default configuration first (base layer)
+         let default_config = ApplicationConfig::default();
+         let default_toml = toml::to_string(&default_config)
+             .map_err(|e| ApplicationError::ConfigurationError(e.to_string()))?;
+
+         let config_builder = Config::builder()
+             .add_source(config::File::from_str(
+                 &default_toml,
+                 config::FileFormat::Toml,
+             ))
+             .add_source(File::from(config_path).required(false))
+             .add_source(Environment::with_prefix("TERRAPHIM"));
 
         let config = config_builder
             .build()

crates/terraphim_agent_application/src/hot_reload.rs

@@ -63,9 +63,9 @@ pub struct ComponentSpec {
     pub config: serde_json::Value,
 }
 
-/// Types of components that can be hot reloaded
-#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
-pub enum ComponentType {
+ /// Types of components that can be hot reloaded
+ #[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq, Hash)]
+ pub enum ComponentType {
     /// Agent behavior
     AgentBehavior,
     /// Configuration
@@ -223,15 +223,13 @@ impl HotReloadManager {
                 component_name, component.component_type
             );
 
-            // Reload dependencies first
-            for dependency in &component.dependencies {
-                if let Err(e) = self
-                    .perform_reload(dependency, ReloadType::Dependency)
-                    .await
-                {
-                    warn!("Failed to reload dependency {}: {}", dependency, e);
-                }
-            }
+             // Reload dependencies first
+             for dependency in &component.dependencies {
+                 if let Err(e) = Box::pin(self.perform_reload(dependency, ReloadType::Dependency)).await
+                 {
+                     warn!("Failed to reload dependency {}: {}", dependency, e);
+                 }
+             }
 
             // Perform the actual reload based on component type and strategy
             match self.reload_component_impl(&component).await {

crates/terraphim_agent_application/src/lifecycle.rs

@@ -13,10 +13,10 @@ use crate::{ApplicationConfig, ApplicationError, ApplicationResult};
 #[async_trait]
 pub trait LifecycleManagement: Send + Sync {
     /// Start lifecycle management
-    async fn start(&self) -> ApplicationResult<()>;
+    async fn start(&mut self) -> ApplicationResult<()>;
 
     /// Stop lifecycle management
-    async fn stop(&self) -> ApplicationResult<()>;
+    async fn stop(&mut self) -> ApplicationResult<()>;
 
     /// Perform health check
     async fn health_check(&self) -> ApplicationResult<bool>;
@@ -56,19 +56,21 @@ impl LifecycleManager {
     }
 }
 
-#[async_trait]
-impl LifecycleManagement for LifecycleManager {
-    async fn start(&self) -> ApplicationResult<()> {
-        info!("Starting lifecycle manager");
-        // In a real implementation, this would initialize lifecycle components
-        Ok(())
-    }
+ #[async_trait]
+ impl LifecycleManagement for LifecycleManager {
+     async fn start(&mut self) -> ApplicationResult<()> {
+         info!("Starting lifecycle manager");
+         self.start_time = Some(SystemTime::now());
+         // In a real implementation, this would initialize lifecycle components
+         Ok(())
+     }
 
-    async fn stop(&self) -> ApplicationResult<()> {
-        info!("Stopping lifecycle manager");
-        // In a real implementation, this would cleanup lifecycle components
-        Ok(())
-    }
+     async fn stop(&mut self) -> ApplicationResult<()> {
+         info!("Stopping lifecycle manager");
+         self.start_time = None;
+         // In a real implementation, this would cleanup lifecycle components
+         Ok(())
+     }
 
     async fn health_check(&self) -> ApplicationResult<bool> {
         debug!("Lifecycle manager health check");

crates/terraphim_kg_orchestration/src/supervision.rs

@@ -524,7 +524,7 @@ impl SupervisionTreeOrchestrator {
     }
 
     /// Shutdown the orchestrator
-    async fn shutdown(&self) -> OrchestrationResult<()> {
+    pub async fn shutdown(&self) -> OrchestrationResult<()> {
         info!("Shutting down supervision tree orchestrator");
 
         // Terminate all active workflows