Merge pull request 'Fix #2508: prefix stub params and remove clippy::all allow in terraphim_validation' (#2853) from task/2508-validation-stub-params into main

Author: AlexMikhalev

crates/terraphim_validation/src/artifacts/mod.rs

@@ -146,7 +146,7 @@ impl ReleaseArtifact {
     fn extract_filename(&self) -> String {
         self.download_url
             .split('/')
-            .last()
+            .next_back()
             .unwrap_or("unknown")
             .to_string()
     }

crates/terraphim_validation/src/lib.rs

@@ -9,7 +9,7 @@
 // TODO: Gradually remove these allows as the crate matures
 #![allow(unused)]
 #![allow(ambiguous_glob_reexports)]
-#![allow(clippy::all)]
+// #![allow(clippy::all)] -- removed: see issue #2508
 
 pub mod artifacts;
 pub mod orchestrator;

crates/terraphim_validation/src/performance/benchmarking.rs

@@ -703,7 +703,7 @@ impl PerformanceBenchmarker {
             max_time: Duration::from_millis(200),
             ops_per_second: user_count as f64 * 2.0,
             success_rate: 0.9,
-            error_count: (user_count / 10) as u32,
+            error_count: (user_count / 10),
             resource_usage: self.capture_resource_usage().await?,
         };
 
@@ -772,11 +772,8 @@ impl PerformanceBenchmarker {
         let disk_write_bytes = 0; // Not easily available from sysinfo
 
         let networks = Networks::new_with_refreshed_list();
-        let network_rx_bytes = networks.iter().map(|(_, network)| network.received()).sum();
-        let network_tx_bytes = networks
-            .iter()
-            .map(|(_, network)| network.transmitted())
-            .sum();
+        let network_rx_bytes = networks.values().map(|network| network.received()).sum();
+        let network_tx_bytes = networks.values().map(|network| network.transmitted()).sum();
 
         Ok(ResourceUsage {
             cpu_percent,
@@ -867,18 +864,16 @@ impl PerformanceBenchmarker {
                         });
                     }
                 }
-                "resource_monitoring_load" => {
-                    if result.resource_usage.cpu_percent > self.config.slos.max_cpu_load_percent {
-                        violations.push(SLOViolation {
-                            metric: "CPU usage during load".to_string(),
-                            actual_value: format!("{:.1}%", result.resource_usage.cpu_percent),
-                            threshold_value: format!(
-                                "{:.1}%",
-                                self.config.slos.max_cpu_load_percent
-                            ),
-                            severity: ViolationSeverity::Warning,
-                        });
-                    }
+                "resource_monitoring_load"
+                    if result.resource_usage.cpu_percent
+                        > self.config.slos.max_cpu_load_percent =>
+                {
+                    violations.push(SLOViolation {
+                        metric: "CPU usage during load".to_string(),
+                        actual_value: format!("{:.1}%", result.resource_usage.cpu_percent),
+                        threshold_value: format!("{:.1}%", self.config.slos.max_cpu_load_percent),
+                        severity: ViolationSeverity::Warning,
+                    });
                 }
                 _ => {} // Other operations don't have specific SLOs yet
             }

crates/terraphim_validation/src/performance/ci_integration.rs

@@ -273,10 +273,10 @@ impl CIPerformanceRunner {
             self.generate_markdown_report(report).await?;
         }
 
-        if self.config.reporting.upload_external {
-            if let Some(url) = &self.config.reporting.upload_url {
-                self.upload_report(report, url).await?;
-            }
+        if self.config.reporting.upload_external
+            && let Some(url) = &self.config.reporting.upload_url
+        {
+            self.upload_report(report, url).await?;
         }
 
         Ok(())
@@ -362,7 +362,7 @@ impl CIPerformanceRunner {
             ));
         }
 
-        content.push_str("\n");
+        content.push('\n');
 
         // SLO violations
         if !report.slo_compliance.violations.is_empty()
@@ -384,7 +384,7 @@ impl CIPerformanceRunner {
                 ));
             }
 
-            content.push_str("\n");
+            content.push('\n');
         }
 
         // Performance trends
@@ -396,7 +396,7 @@ impl CIPerformanceRunner {
                 for (operation, change) in &trends.improvements {
                     content.push_str(&format!("✅ **{}:** {:.1}% faster\n", operation, change));
                 }
-                content.push_str("\n");
+                content.push('\n');
             }
 
             if !trends.regressions.is_empty() {
@@ -408,15 +408,15 @@ impl CIPerformanceRunner {
                         change.abs()
                     ));
                 }
-                content.push_str("\n");
+                content.push('\n');
             }
 
             if !trends.new_operations.is_empty() {
                 content.push_str("### New Operations\n\n");
                 for operation in &trends.new_operations {
                     content.push_str(&format!("🆕 **{}:** New benchmark added\n", operation));
                 }
-                content.push_str("\n");
+                content.push('\n');
             }
         }
 
@@ -563,10 +563,10 @@ impl CLIInterface {
                         println!("🚫 {}", failure.message);
                     }
 
-                    return Ok(1); // Non-zero exit code for CI failure
+                    Ok(1) // Non-zero exit code for CI failure
                 } else {
                     println!("✅ All performance gates passed");
-                    return Ok(0); // Success exit code
+                    Ok(0) // Success exit code
                 }
             }
             Err(e) => {

crates/terraphim_validation/src/testing/desktop_ui/accessibility.rs

@@ -18,6 +18,7 @@ pub struct AccessibilityTestConfig {
 }
 
 #[derive(Debug, Clone, Serialize, Deserialize)]
+#[allow(clippy::upper_case_acronyms)] // AAA is the established WCAG accessibility conformance level name
 pub enum WCAGLevel {
     A,
     AA,
@@ -95,7 +96,7 @@ impl AccessibilityTester {
 
         for screen_reader in &self.config.screen_readers {
             if screen_reader.enabled {
-                results.push(self.test_screen_reader(&screen_reader).await?);
+                results.push(self.test_screen_reader(screen_reader).await?);
             }
         }
 

crates/terraphim_validation/src/testing/desktop_ui/cross_platform.rs

@@ -117,10 +117,10 @@ impl CrossPlatformUITester {
             }
 
             // Test Touch Bar
-            if let Some(touch_bar) = &macos_config.touch_bar {
-                if touch_bar.enabled {
-                    results.push(self.test_macos_touch_bar().await?);
-                }
+            if let Some(touch_bar) = &macos_config.touch_bar
+                && touch_bar.enabled
+            {
+                results.push(self.test_macos_touch_bar().await?);
             }
         }
 

crates/terraphim_validation/src/testing/desktop_ui/harness.rs

@@ -7,7 +7,7 @@ use crate::testing::ValidationResult;
 use anyhow::{Result, anyhow};
 use serde::{Deserialize, Serialize};
 use std::collections::HashMap;
-use std::path::PathBuf;
+use std::path::{Path, PathBuf};
 use std::process::Stdio;
 use std::time::{Duration, Instant};
 use tokio::process::Command;
@@ -261,7 +261,7 @@ impl PlaywrightClient {
         Ok(vec!["main".to_string()])
     }
 
-    async fn take_screenshot(&self, path: &PathBuf) -> Result<()> {
+    async fn take_screenshot(&self, path: &Path) -> Result<()> {
         // Take screenshot using Playwright
         Ok(())
     }

crates/terraphim_validation/src/testing/desktop_ui/orchestrator.rs

@@ -399,26 +399,25 @@ impl DesktopUITestOrchestrator {
                     UITestStatus::Error => "fail",
                 };
 
+                let status_str = format!("{:?}", result.status);
+                let message_html = result
+                    .message
+                    .as_ref()
+                    .map(|msg| format!("<p><strong>Message:</strong> {}</p>", msg))
+                    .unwrap_or_default();
+                let details_html = result
+                    .details
+                    .as_ref()
+                    .map(|details| format!("<p><strong>Details:</strong> {}</p>", details))
+                    .unwrap_or_default();
                 format!(
                     r#"<div class="test-result {}">
                         <h3>{}</h3>
                         <p><strong>Status:</strong> {}</p>
                         {}
                         {}
                     </div>"#,
-                    css_class,
-                    result.name,
-                    format!("{:?}", result.status),
-                    result
-                        .message
-                        .as_ref()
-                        .map(|msg| format!("<p><strong>Message:</strong> {}</p>", msg))
-                        .unwrap_or_default(),
-                    result
-                        .details
-                        .as_ref()
-                        .map(|details| format!("<p><strong>Details:</strong> {}</p>", details))
-                        .unwrap_or_default()
+                    css_class, result.name, status_str, message_html, details_html
                 )
             })
             .collect::<Vec<_>>()

crates/terraphim_validation/src/testing/desktop_ui/performance.rs

@@ -266,8 +266,8 @@ impl PerformanceTester {
         }
 
         let avg_time = times.iter().sum::<Duration>() / times.len() as u32;
-        let min_time = times.iter().min().unwrap().clone();
-        let max_time = times.iter().max().unwrap().clone();
+        let min_time = *times.iter().min().unwrap();
+        let max_time = *times.iter().max().unwrap();
 
         Ok(BenchmarkResult {
             operation: operation.name.clone(),

crates/terraphim_validation/src/testing/desktop_ui/utils.rs

@@ -108,27 +108,27 @@ pub struct ScreenshotComparison {
 pub struct ElementUtils;
 
 impl ElementUtils {
-    /// Wait for element to be visible with timeout
-    pub async fn wait_for_element_visible(selector: &str, timeout: Duration) -> Result<bool> {
-        // Implementation would use Playwright to wait for element
+    /// Wait for element to be visible with timeout.
+    /// Stub: Playwright integration not yet implemented; always returns Ok(true).
+    pub async fn wait_for_element_visible(_selector: &str, _timeout: Duration) -> Result<bool> {
         tokio::time::sleep(Duration::from_millis(100)).await;
         Ok(true)
     }
 
-    /// Wait for element to contain specific text
+    /// Wait for element to contain specific text.
+    /// Stub: Playwright integration not yet implemented; always returns Ok(true).
     pub async fn wait_for_text(
-        selector: &str,
-        expected_text: &str,
-        timeout: Duration,
+        _selector: &str,
+        _expected_text: &str,
+        _timeout: Duration,
     ) -> Result<bool> {
-        // Implementation would wait for text to appear
         tokio::time::sleep(Duration::from_millis(100)).await;
         Ok(true)
     }
 
-    /// Wait for element to be clickable
-    pub async fn wait_for_clickable(selector: &str, timeout: Duration) -> Result<bool> {
-        // Implementation would wait for element to be clickable
+    /// Wait for element to be clickable.
+    /// Stub: Playwright integration not yet implemented; always returns Ok(true).
+    pub async fn wait_for_clickable(_selector: &str, _timeout: Duration) -> Result<bool> {
         tokio::time::sleep(Duration::from_millis(100)).await;
         Ok(true)
     }