Skip to content

Commit 6d59e57

Browse files
Test Userclaude
andcommitted
docs(reports): correct spec-validation 2026-06-29 verdict to CONDITIONAL PASS
Initial verdict was PASS (overconfident). Re-measured stranded source after reading the 04:36 cron run's handover: excluded 'empty/residual' dirs actually contain 26,551 LOC of git-tracked .rs (orchestrator 16,467 + agent 6,819 + agent_application 3,265) — a real hygiene gap already tracked as #2972. No behavioural AC violation; all plan code intact & tested in terraphim-agents polyrepo (288 tests green). Verdict corrected to CONDITIONAL PASS; gap is already filed and recurred by the earlier run today, so no new issue created. Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 87141e0 commit 6d59e57

1 file changed

Lines changed: 53 additions & 20 deletions

File tree

reports/spec-validation-20260629.md

Lines changed: 53 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,18 @@
22

33
**Agent**: spec-validator (Carthos, Domain Architect)
44
**Date**: 2026-06-29 05:30 CEST
5-
**Verdict**: PASS (with one P2 spec-location drift note)
5+
**Verdict**: CONDITIONAL PASS (1 open tracked gap #2972, re-confirmed)
66
**Prior verdict**: CONDITIONAL PASS (2026-06-01)
77

8+
> **Correction note (05:50 CEST).** My initial verdict on this cycle was PASS. That was
9+
> **overconfident**: I verified the plan-referenced code exists *somewhere* (the
10+
> `terraphim-agents` polyrepo) and concluded "navigational drift only." I did **not** check
11+
> whether stale copies of that code were left stranded in *this* repo. They were. An earlier
12+
> spec-validator cron run today (04:36 CEST) correctly caught this and filed a recurrence on
13+
> #2972. After reading that run's handover, I re-measured the stranded source and confirmed it.
14+
> Verdict corrected to **CONDITIONAL PASS**. The gap is already tracked (#2972, open); the
15+
> measurement below is this cycle's contribution.
16+
817
---
918

1019
## Boundary Event Since Last Cycle
@@ -89,23 +98,44 @@ Includes `shared_learning::wiki_sync::tests` and `robot::output::proptests`. Gre
8998

9099
---
91100

92-
## The One Gap: Spec-Location Drift (P2)
101+
## The Gap: Stranded Source + Spec-Location Drift (P2, tracked as #2972)
102+
103+
Two facets of one root cause — the polyrepo extraction (#1910) left debris in this repo.
104+
105+
### Facet A — Stranded source code (re-confirmed this cycle)
106+
107+
The workspace `exclude` block (Cargo.toml) labels these dirs as "empty/residual." They are
108+
**not**. Git-tracked Rust source with no workspace build path remains:
93109

94-
| Severity | Finding |
95-
|----------|---------|
96-
| ⚠️ P2 | The six `plans/*.md` documents cite paths like `crates/terraphim_agent/src/learnings/capture.rs` that **no longer exist in this repo** after the E4a extraction. A reader following the plans in `terraphim-ai` will find only a residual/excluded empty `crates/terraphim_agent/` dir and an `src/` containing `client.rs`, `commands/`, `repl/` — no `learnings/`. |
110+
| Directory | Tracked files | LOC (.rs) | Cargo.toml |
111+
|-----------|--------------|-----------|------------|
112+
| `crates/terraphim_orchestrator` | 18 | **16,467** | none (orphaned mod roots) |
113+
| `crates/terraphim_agent` | 7 | **6,819** | none |
114+
| `crates/terraphim_agent_application` | 9 | **3,265** | **still present** |
115+
| **subtotal** | **34** | **26,551** ||
97116

98-
**Why P2, not P1:** This is documentation drift, not a functional/behavioural spec violation.
99-
The specified behaviour is fully implemented and tested in `terraphim-agents`; the plans simply
100-
describe a pre-extraction topology. No acceptance criterion is unmet. The drift is a
101-
**navigational** defect: it impedes a future implementer who reads the plan in this repo and
102-
cannot locate the code.
117+
Hazard: dead-but-tracked code that is (a) excluded from the build, (b) superseded by registry
118+
deps, yet (c) still present and searchable — a maintenance trap and review-noise source. The
119+
earlier 04:36 run measured "~23,286 LOC"; this cycle's fuller count is **26,551** (the
120+
difference is `terraphim_agent_application`, which that run may not have included).
103121

104-
**Smallest fix:** add a single banner to each affected plan — e.g.:
122+
### Facet B — Spec-location drift
105123

106-
> **Note (2026-06-29):** The `learnings/` module referenced herein was extracted to the
107-
> `terraphim-agents` polyrepo (Gitea #1910, E4a) and is consumed as a registry dependency.
108-
> Authoritative source: `terraphim-agents/crates/terraphim_agent/src/learnings/`.
124+
The six `plans/*.md` cite pre-extraction paths (`crates/terraphim_agent/src/learnings/...`)
125+
unresolvable in this repo. Behavioural ACs are satisfied in the code's true home
126+
(`terraphim-agents` + `terraphim-core` registry crates); the plans describe a dead topology.
127+
128+
### Why CONDITIONAL PASS, not FAIL
129+
130+
No behavioural / acceptance-criterion violation exists — every specified function is
131+
implemented and tested in its polyrepo. The gap is **repository hygiene + spec relocation**,
132+
already filed as **#2972** (open, assigned quality-coordinator, 21 comments) and recurred by
133+
the 04:36 run today. This cycle re-confirms it with fresh LOC measurement. No new issue
134+
warranted; the fix owner is unchanged.
135+
136+
**Smallest fix** (owned by whoever closes #2972): `git rm` the stranded `crates/*` source
137+
(except any genuinely-shared fixtures), add relocation banners to the 4 code-bearing plans,
138+
and replace `plans/` with a `RELOCATED.md` index.
109139

110140
---
111141

@@ -125,12 +155,15 @@ To prevent re-work loops, these were considered and ruled out:
125155

126156
## Verdict
127157

128-
**PASS.** No P0/P1 spec violations. Behavioural acceptance criteria for all six plans are
129-
satisfied in the code's true home (`terraphim-agents` + `terraphim-core` registry crates).
130-
The sole finding is a P2 documentation-drift note: the `plans/` artefacts in this repo
131-
reference pre-extraction paths. This is navigational, not behavioural, and is below the
132-
cron-report threshold for filing a new Gitea issue (no functional gap; fixable via a
133-
documentation banner). Per cron protocol, exiting silently after recording this report.
158+
**CONDITIONAL PASS.** No P0/P1 behavioural spec violations. All six plans' acceptance
159+
criteria are satisfied in the code's true home (`terraphim-agents` + `terraphim-core` registry
160+
crates); `terraphim_agent` lib suite = 288 passed. Two carry-forwards from 2026-06-01
161+
cleared (Phase G shared-learning CLI wired; Phase I evolution mocks confined to tests).
162+
163+
One tracked P2 gap re-confirmed: stranded source (~26,551 LOC across 3 excluded dirs) +
164+
spec-location drift in `plans/`. Already filed as **#2972** (open) and recurred by an earlier
165+
cron run today (04:36 CEST). This cycle adds the precise LOC measurement. No new issue filed
166+
(fix owner unchanged; duplicate noise avoided per cron protocol).
134167

135168
## Traceability
136169

0 commit comments

Comments
 (0)