fix(rlm): wire firecracker feature with local fcctl-core + terraphim-firecracker dependencies

Added path dependencies for fcctl-core (firecracker-rust repo) and
terraphim-firecracker (workspace member). Fixed FirecrackerExecutor::new()
constructor calls in tests to pass validator=None.

Builds with --features firecracker: 152 tests pass.

Author: Test User

crates/terraphim_rlm/Cargo.toml

@@ -40,7 +40,8 @@ terraphim_mcp_search = { version = "0.1.0", registry = "terraphim", optional = t
 # Firecracker-rust core for VM and snapshot management (private repo).
 # Uncomment when building with --features firecracker on a machine with
 # access to the private firecracker-rust repository.
-# fcctl-core = { git = "https://github.com/terraphim/firecracker-rust", branch = "main", optional = true }
+fcctl-core = { path = "/home/alex/projects/terraphim/firecracker-rust/fcctl-core", optional = true }
+terraphim-firecracker = { path = "../../terraphim_firecracker", optional = true, package = "terraphim-firecracker" }
 
 # Async utilities
 tokio-util = "0.7"
@@ -85,7 +86,7 @@ kg-validation = ["dep:terraphim_automata", "dep:terraphim_types", "dep:terraphim
 supervision = ["dep:terraphim_agent_supervisor"]
 llm-bridge = ["dep:hyper", "dep:hyper-util"]
 docker-backend = ["dep:bollard"]
-firecracker = []
+firecracker = ["dep:fcctl-core", "dep:terraphim-firecracker"]
 e2b-backend = ["dep:reqwest"]
 mcp = ["dep:rmcp", "dep:terraphim_mcp_search", "dep:terraphim_types"]
 cli = ["dep:clap", "dep:env_logger"]

crates/terraphim_rlm/src/executor/firecracker.rs

@@ -841,7 +841,7 @@ mod tests {
         }
 
         let config = RlmConfig::default();
-        let executor = FirecrackerExecutor::new(config).unwrap();
+        let executor = FirecrackerExecutor::new(config, None).unwrap();
 
         assert!(executor.has_capability(Capability::VmIsolation));
         assert!(executor.has_capability(Capability::Snapshots));
@@ -857,7 +857,7 @@ mod tests {
         }
 
         let config = RlmConfig::default();
-        let result = FirecrackerExecutor::new(config);
+        let result = FirecrackerExecutor::new(config, None);
         assert!(result.is_err());
     }
 
@@ -869,7 +869,7 @@ mod tests {
         }
 
         let config = RlmConfig::default();
-        let executor = FirecrackerExecutor::new(config).unwrap();
+        let executor = FirecrackerExecutor::new(config, None).unwrap();
         let session_id = SessionId::new();
 
         // Initially no VM assigned
@@ -898,7 +898,7 @@ mod tests {
         }
 
         let config = RlmConfig::default();
-        let executor = FirecrackerExecutor::new(config).unwrap();
+        let executor = FirecrackerExecutor::new(config, None).unwrap();
         let session_id = SessionId::new();
 
         // Initially no current snapshot
@@ -924,7 +924,7 @@ mod tests {
         }
 
         let config = RlmConfig::default();
-        let executor = FirecrackerExecutor::new(config).unwrap();
+        let executor = FirecrackerExecutor::new(config, None).unwrap();
         let session_id = SessionId::new();
 
         // Rollback without any snapshot should be no-op
@@ -940,7 +940,7 @@ mod tests {
         }
 
         let config = RlmConfig::default();
-        let executor = FirecrackerExecutor::new(config).unwrap();
+        let executor = FirecrackerExecutor::new(config, None).unwrap();
 
         // Health check should fail if not initialized
         let result = executor.health_check().await.unwrap();
@@ -955,7 +955,7 @@ mod tests {
         }
 
         let config = RlmConfig::default();
-        let executor = FirecrackerExecutor::new(config).unwrap();
+        let executor = FirecrackerExecutor::new(config, None).unwrap();
 
         let session_id1 = SessionId::new();
         let session_id2 = SessionId::new();