Skip to content

Commit f91725d

Browse files
AlexMikhalevclaude
andcommitted
fix(scripts): resolve merge conflicts in test-vm-execution.sh
Resolve merge conflicts by keeping the improved CI handling that: - Checks if fcctl-web directory exists before attempting to use it - Sets NO_FCCTL_WEB=true for CI environments where code is gitignored - Gracefully skips tests when fcctl-web is not present Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 2432662 commit f91725d

1 file changed

Lines changed: 0 additions & 34 deletions

File tree

scripts/test-vm-execution.sh

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -202,16 +202,6 @@ check_dependencies() {
202202
exit 1
203203
fi
204204

205-
<<<<<<< HEAD
206-
# Check for fcctl-web binary if we need to start server
207-
if [ "$START_SERVER" = true ]; then
208-
if [ ! -f "scratchpad/firecracker-rust/fcctl-web/target/debug/fcctl-web" ] &&
209-
[ ! -f "scratchpad/firecracker-rust/fcctl-web/target/release/fcctl-web" ]; then
210-
log_info "Building fcctl-web server..."
211-
cd scratchpad/firecracker-rust/fcctl-web
212-
cargo build --release
213-
cd - > /dev/null
214-
=======
215205
# Check if fcctl-web directory exists
216206
if [ ! -d "scratchpad/firecracker-rust/fcctl-web" ]; then
217207
log_warning "fcctl-web directory not found (scratchpad/firecracker-rust/fcctl-web)"
@@ -228,7 +218,6 @@ check_dependencies() {
228218
cargo build --release
229219
cd - > /dev/null
230220
fi
231-
>>>>>>> origin/main
232221
fi
233222
fi
234223

@@ -241,14 +230,11 @@ start_server() {
241230
return
242231
fi
243232

244-
<<<<<<< HEAD
245-
=======
246233
if [ "${NO_FCCTL_WEB:-false}" = true ]; then
247234
log_warning "Skipping fcctl-web server start - directory not present (expected for CI)"
248235
return
249236
fi
250237

251-
>>>>>>> origin/main
252238
log_info "Starting fcctl-web server..."
253239

254240
cd scratchpad/firecracker-rust/fcctl-web
@@ -284,14 +270,11 @@ start_server() {
284270
check_server() {
285271
log_info "Checking fcctl-web server availability..."
286272

287-
<<<<<<< HEAD
288-
=======
289273
if [ "${NO_FCCTL_WEB:-false}" = true ]; then
290274
log_warning "Skipping server check - fcctl-web not present (expected for CI)"
291275
return
292276
fi
293277

294-
>>>>>>> origin/main
295278
if curl -s "$FCCTL_WEB_URL/health" > /dev/null 2>&1; then
296279
log_success "fcctl-web server is available at $FCCTL_WEB_URL"
297280
else
@@ -325,14 +308,11 @@ run_unit_tests() {
325308
run_integration_tests() {
326309
log_info "Running integration tests..."
327310

328-
<<<<<<< HEAD
329-
=======
330311
if [ "${NO_FCCTL_WEB:-false}" = true ]; then
331312
log_warning "Skipping integration tests - fcctl-web not present (expected for CI)"
332313
return 0
333314
fi
334315

335-
>>>>>>> origin/main
336316
cd scratchpad/firecracker-rust/fcctl-web
337317

338318
local test_args=()
@@ -356,14 +336,11 @@ run_integration_tests() {
356336
run_websocket_tests() {
357337
log_info "Running WebSocket tests..."
358338

359-
<<<<<<< HEAD
360-
=======
361339
if [ "${NO_FCCTL_WEB:-false}" = true ]; then
362340
log_warning "Skipping WebSocket tests - fcctl-web not present (expected for CI)"
363341
return 0
364342
fi
365343

366-
>>>>>>> origin/main
367344
cd scratchpad/firecracker-rust/fcctl-web
368345

369346
local test_args=("--ignored")
@@ -387,14 +364,11 @@ run_websocket_tests() {
387364
run_e2e_tests() {
388365
log_info "Running end-to-end tests..."
389366

390-
<<<<<<< HEAD
391-
=======
392367
if [ "${NO_FCCTL_WEB:-false}" = true ]; then
393368
log_warning "Skipping end-to-end tests - fcctl-web not present (expected for CI)"
394369
return 0
395370
fi
396371

397-
>>>>>>> origin/main
398372
local test_args=("--ignored")
399373
if [ "$VERBOSE" = true ]; then
400374
test_args+=("--" "--nocapture")
@@ -432,10 +406,6 @@ run_security_tests() {
432406
else
433407
log_warning "Skipping integration security tests - fcctl-web not present (expected for CI)"
434408
fi
435-
<<<<<<< HEAD
436-
cd - > /dev/null
437-
=======
438-
>>>>>>> origin/main
439409

440410
if [ $result -eq 0 ]; then
441411
log_success "Security tests passed"
@@ -467,10 +437,6 @@ run_performance_tests() {
467437
else
468438
log_warning "Skipping integration performance tests - fcctl-web not present (expected for CI)"
469439
fi
470-
<<<<<<< HEAD
471-
cd - > /dev/null
472-
=======
473-
>>>>>>> origin/main
474440

475441
# Agent performance tests
476442
if ! cargo test agent_performance_tests --ignored --release 2>&1 | tee -a "$LOG_FILE"; then

0 commit comments

Comments
 (0)