Review GitHub Actions failure and create fix#317
Conversation
…tions - Replace deprecated actions-rs/toolchain@v1 with dtolnay/rust-toolchain - test-on-pr-desktop.yml (1 occurrence) - vm-execution-tests.yml (7 occurrences including nightly) - Update removed/deprecated GitHub-hosted runners - Remove ubuntu-18.04 (no longer available since April 2023) - Update ubuntu-20.04 to ubuntu-22.04/24.04 where applicable - Fix webkit and javascriptcore packages from 4.0 to 4.1 versions - Update tauri-apps/tauri-action from v0 to v0.5 - Fix frontend-build.yml cache from npm to yarn (matches project config) - Standardize Rust toolchain to 1.87.0 in tauri-build.yml
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - platform: ubuntu-22.04 | ||
| webkit-package: "libwebkit2gtk-4.0-dev" | ||
| webkit-package: "libwebkit2gtk-4.1-dev" | ||
| javascriptcore-package: "libjavascriptcoregtk-4.1-dev" |
There was a problem hiding this comment.
The Ubuntu leg of the tauri desktop release matrix now asks for libwebkit2gtk-4.1-dev and libjavascriptcoregtk-4.1-dev, but Ubuntu 22.04 only provides the 4.0 variants. On the ubuntu-22.04 runner this apt step will fail with “Unable to locate package” before any build logic runs, breaking desktop artifact publishing for that platform. Consider keeping 4.0 on 22.04 (or switching the runner to 24.04) so the workflow can install dependencies.
Useful? React with 👍 / 👎.
| - platform: ubuntu-22.04 | ||
| webkit-package: "libwebkit2gtk-4.0-dev" | ||
| webkit-package: "libwebkit2gtk-4.1-dev" | ||
| javascriptcore-package: "libjavascriptcoregtk-4.1-dev" |
There was a problem hiding this comment.
The PR desktop test matrix now installs libwebkit2gtk-4.1-dev and libjavascriptcoregtk-4.1-dev on ubuntu-22.04, but those package names are not available in 22.04’s default repositories (only the 4.0 variants exist). The “Install dependencies (Ubuntu only)” step will therefore fail on the 22.04 runner before the Tauri build runs, causing the PR workflow to fail for Linux. Use the 4.0 packages on 22.04 or run the job on 24.04 where 4.1 exists.
Useful? React with 👍 / 👎.
AlexMikhalev
deleted the
claude/fix-github-actions-01BaFSR3QvaViw4AhVxem7Zk
branch
…FSR3QvaViw4AhVxem7Zk Review GitHub Actions failure and create fix
…FSR3QvaViw4AhVxem7Zk Review GitHub Actions failure and create fix
2 participants
…tions