More tests and type fixes

Author: terremoth

README.md

@@ -8,6 +8,7 @@ Just raw PHP! It is magic! This is **not** the classical meaning of async like p
 [![codecov](https://codecov.io/gh/terremoth/php-async/graph/badge.svg?token=W37V5EDERQ)](https://codecov.io/gh/terremoth/php-async)
 [![Test Coverage](https://api.codeclimate.com/v1/badges/c6420e5f6ab01e70eed7/test_coverage)](https://codeclimate.com/github/terremoth/php-async/test_coverage)
 -->
+[![Code Coverage](https://qlty.sh/gh/terremoth/projects/php-async/coverage.svg)](https://qlty.sh/gh/terremoth/projects/php-async)
 [![Psalm type coverage](https://shepherd.dev/github/terremoth/php-async/coverage.svg)](https://shepherd.dev/github/terremoth/php-async)
 [![Psalm level](https://shepherd.dev/github/terremoth/php-async/level.svg)](https://shepherd.dev/github/terremoth/php-async)
 [![Test Run Status](https://github.com/terremoth/php-async/actions/workflows/workflow.yml/badge.svg?branch=main)](https://github.com/terremoth/php-async/actions/workflows/workflow.yml)

composer.json

@@ -31,7 +31,10 @@
     "autoload-dev": {
         "psr-4": {
             "\\Tests\\": "tests/"
-        }
+        },
+        "files": [
+            "src/Terremoth/Async/script_functions.php"
+        ]
     },
     "authors": [
         {

demo-file.txt

@@ -0,0 +1 @@
+Hello users! At: 2026-01-15T09:46:38+00:00

src/Terremoth/Async/Process.php

@@ -5,6 +5,7 @@
 use Closure;
 use Exception;
 use Laravel\SerializableClosure\SerializableClosure;
+use Shmop;
 
 class Process
 {
@@ -22,12 +23,11 @@ public function __construct(private int $shmopKey = 0)
      */
     public function send(Closure $asyncFunction): void
     {
-        $dirSlash = DIRECTORY_SEPARATOR;
         $serialized = serialize(new SerializableClosure($asyncFunction));
         $length = mb_strlen($serialized);
 
-        set_error_handler(function (int $errno, string $error) {
-            throw new Exception($error);
+        set_error_handler(function (int $errorNumber, string $error) {
+            throw new Exception($error . ' - ' . $errorNumber);
         });
 
         try {
@@ -60,15 +60,37 @@ public function send(Closure $asyncFunction): void
             restore_error_handler();
         }
 
-        $bytesWritten = shmop_write($shmopInstance, $serialized, 0);
+        $bytesWritten = $this->writeToShmop($shmopInstance, $serialized, 0);
 
-        if ($bytesWritten < $length) {
-            throw new Exception('Error: Could not write the entire data to shared memory with length: ' .
-                $length . '. Bytes written: ' . $bytesWritten . PHP_EOL);
+        if ((bool)$bytesWritten === false) {
+            throw new Exception(
+                'shmop_write failed when writing to shared memory with key: ' . $this->shmopKey
+            );
         }
 
-        $fileWithPath = __DIR__ . $dirSlash . 'background_processor.php';
-        $file = new PhpFile($fileWithPath, [(string)$this->shmopKey]);
+        if ($bytesWritten !== $length) {
+            throw new Exception(
+                'Could not write all bytes to shared memory. Expected: '
+                . $length . ', Written: ' . (int)$bytesWritten
+            );
+        }
+
+        $file = new PhpFile(
+            __DIR__ . DIRECTORY_SEPARATOR . 'background_processor.php',
+            [(string) $this->shmopKey]
+        );
+
         $file->run();
     }
+
+    /**
+     * @param Shmop $shmopInstance
+     * @param string $data
+     * @param int $offset
+     * @return int|false
+     */
+    protected function writeToShmop(Shmop $shmopInstance, string $data, int $offset): int|false
+    {
+        return shmop_write($shmopInstance, $data, $offset);
+    }
 }

src/Terremoth/Async/background_processor.php

@@ -1,5 +1,7 @@
 <?php
 
+namespace Terremoth\Async;
+
 ini_set('display_errors', 'on');
 ini_set('display_startup_errors', 1);
 ini_set('error_log', 'php-async-errors-' . date('YmdH') . '.log');
@@ -11,7 +13,7 @@
 use Laravel\SerializableClosure\SerializableClosure;
 
 if (!isset($argv[1])) {
-    error('Shmop Key not provided');
+    custom_error('Shmop Key not provided');
     exit(1);
 }
 
@@ -20,14 +22,14 @@
 $shmopInstance = shmop_open($key, 'a', 0, 0);
 
 if (!$shmopInstance) {
-    error('Could not open Shmop');
+    custom_error('Could not open Shmop');
     exit(1);
 }
 
 $length = shmop_size($shmopInstance);
 
 if ($length === 0) {
-    error('Shmop length cannot be zero!');
+    custom_error('Shmop length cannot be zero!');
     exit(1);
 }
 

src/Terremoth/Async/script_functions.php

@@ -1,6 +1,8 @@
 <?php
 
-function error(string $error): void
+namespace Terremoth\Async;
+
+function custom_error(string $error): void
 {
     $error = 'Error: ' . $error;
     fwrite(STDERR, $error);

tests/Terremoth/AsyncTest/PhpFileTest.php

@@ -12,7 +12,7 @@
  */
 class PhpFileTest extends TestCase
 {
-    private string $tmpDir;
+    private string $tmpDir = '';
 
     protected function setUp(): void
     {
@@ -23,8 +23,9 @@ protected function setUp(): void
 
     protected function tearDown(): void
     {
-        array_map('unlink', glob($this->tmpDir . '/*'));
-        rmdir($this->tmpDir);
+        foreach (glob($this->tmpDir . '/*') as $file) {
+            unlink($file);
+        }
     }
 
     private function makeFile(string $name, string $content): string

tests/Terremoth/AsyncTest/ProcessTest.php

@@ -65,13 +65,10 @@ public function testSendActuallyWritesSerializedClosureToShmop(): void
 
         $raw = shmop_read($shmop, 0, $size);
         $data = rtrim($raw, "\0");
-        $this->assertIsString($data);
-
         $unserialized = unserialize($data);
         $this->assertInstanceOf(SerializableClosure::class, $unserialized);
 
-        $func = $unserialized->getClosure();
-        $this->assertIsCallable($func);
+        $unserialized->getClosure();
 
         // shmop_delete($shmop);
         // shmop_close($shmop); // deprecated
@@ -90,32 +87,26 @@ public function testSendThrowsWhenShmopCannotBeCreated(): void
     }
 
     /**
-     * @throws RandomException
+     * @throws RandomException|Exception
      */
     public function testSendThrowsWhenNotAllBytesAreWritten(): void
     {
         $key = ftok(__FILE__, 'b') ?: random_int(1, 1000000);
 
         $process = $this->getMockBuilder(Process::class)
             ->setConstructorArgs([$key])
-            ->onlyMethods([])
+            ->onlyMethods(['writeToShmop'])
             ->getMock();
 
-        serialize(new SerializableClosure(function () {
-        }));
-
-        $shmop = shmop_open($key, 'c', 0660, 1);
-        // shmop_close($shmop); // deprecated function
+        $process
+            ->expects($this->once())
+            ->method('writeToShmop')
+            ->willReturn(10);
 
         $this->expectException(Exception::class);
 
         $process->send(function () {
         });
-
-        $this->assertNotFalse($shmop);
-        if ($shmop) {
-            shmop_delete($shmop);
-        }
     }
 
     /**
@@ -133,11 +124,9 @@ public function testSendDoesNotThrowOnSuccess(): void
         });
 
         $shmop = shmop_open($key, 'a', 0, 0);
-        if ($shmop) {
-            $this->assertTrue(shmop_delete($shmop));
-            // shmop_close($shmop); // deprecated function
-        } else {
-            $this->expectNotToPerformAssertions();
-        }
+        $this->assertNotFalse($shmop, 'Shared memory should exist after send');
+
+        $size = shmop_size($shmop);
+        $this->assertGreaterThan(0, $size, 'Shared memory should contain data');
     }
 }

tests/Terremoth/AsyncTest/ScriptFunctionsTest.php

@@ -0,0 +1,62 @@
+<?php
+
+namespace Terremoth\AsyncTest;
+
+use PHPUnit\Framework\TestCase;
+
+use function Terremoth\Async\stringFromMemoryBlock;
+
+/**
+ * @covers \Terremoth\Async\stringFromMemoryBlock
+ * @covers \Terremoth\Async\error
+ */
+class ScriptFunctionsTest extends TestCase
+{
+    public function testStringFromMemoryBlockTrimsNull(): void
+    {
+        $this->assertSame('Hello', stringFromMemoryBlock("Hello\0World"));
+    }
+
+    public function testStringFromMemoryBlockWithoutNull(): void
+    {
+        $this->assertSame('JustAString', stringFromMemoryBlock("JustAString"));
+    }
+
+    public function testStringFromMemoryBlockHandlesLeadingNullByte(): void
+    {
+        $this->assertSame('', stringFromMemoryBlock("\0LeadingNull"));
+    }
+
+    public function testStringFromMemoryBlockHandlesMultipleNullBytes(): void
+    {
+        $this->assertSame('A', stringFromMemoryBlock("A\0B\0C"));
+    }
+
+    public function testErrorWritesToStderrAndErrorLog(): void
+    {
+        $logFile = sys_get_temp_dir() . '/phpunit_error.log';
+        ini_set('error_log', $logFile);
+
+        $stream = fopen('php://memory', 'w+');
+
+        // temporarily redefine error() for test
+        $customError = function (string $msg) use ($stream): void {
+            $msg = 'Error: ' . $msg;
+            fwrite($stream, $msg);
+            error_log($msg);
+        };
+
+        ob_start(); // start output buffer
+        $customError('Test Error');
+        ob_get_clean(); // clean buffer properly
+
+        rewind($stream);
+        $streamContents = stream_get_contents($stream);
+        fclose($stream);
+
+        $this->assertStringContainsString('Error: Test Error', $streamContents);
+
+        $logContents = file_get_contents($logFile);
+        $this->assertStringContainsString('Error: Test Error', $logContents);
+    }
+}