Fixing cookstyle PR check introduced in PR#622 to unblock the auto release#651
Merged
Merged
Conversation
3s Run bundle exec cookstyle --chefstyle Inspecting 21 files ...................C. Offenses: Error: lib/kitchen/driver/ec2.rb:589:56: C: [Correctable] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. (https://rubystyle.guide#consistent-string-literals) output = server.console_output.output || '' ^^ 21 files inspected, 1 offense detected, 1 offense autocorrectable Error: Process completed with exit code 1. https://github.com/test-kitchen/kitchen-ec2/pull/622/files Signed-off-by: mayankgupta57 <mayank.g57@gmail.com>
mayankgupta57
changed the title
Contributor
Author
|
@damacus Can you please help with the release of latest version. We need the latest release for ssm session manager feature. |
Stromweld
approved these changes
Jan 22, 2026
Contributor
|
Not sure how this got missed in your PR. Can you create a new pr with this information please. Otherwise the release system won't know what to release. |
Contributor
|
I was able to fix that in the squash merge I added the fix: prefix. release please updated release PR for the added changes. since it wasn't published yet it didn't bump the version a second time. |
Contributor
|
This is released and in https://rubygems.org/gems/kitchen-ec2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3s
Run bundle exec cookstyle --chefstyle
Inspecting 21 files
...................C.
Offenses:
Error: lib/kitchen/driver/ec2.rb:589:56: C: [Correctable] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. (https://rubystyle.guide#consistent-string-literals)
output = server.console_output.output || ''
^^
21 files inspected, 1 offense detected, 1 offense autocorrectable Error: Process completed with exit code 1.
PR which introduced the failure: https://github.com/test-kitchen/kitchen-ec2/pull/622/files
Error: https://github.com/test-kitchen/kitchen-ec2/actions/runs/20807432531/job/59764381382?pr=650
Description
Please describe what this change achieves
Issues Resolved
List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant
Type of Change
Our release process assumes you are using Conventional Commit messages.
The most important prefixes you should have in mind are:
_fix_: which represents bug fixes, and correlates to a SemVer patch._feat_: which represents a new feature, and correlates to a SemVer minor._feat!_:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a major version change.If you have not included a conventional commit message this can be fixed on merge.
Check List