feat: Set nullable for generated model classes (#93)

Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>

Author: campersau

src/Docker.DotNet/Endpoints/ContainerOperations.cs

@@ -45,11 +45,7 @@ public async Task<CreateContainerResponse> CreateContainerAsync(CreateContainerP
             throw new ArgumentNullException(nameof(parameters));
         }
 
-        IQueryString? queryParameters = null;
-        if (!string.IsNullOrEmpty(parameters.Name))
-        {
-            queryParameters = new QueryString<CreateContainerParameters>(parameters);
-        }
+        var queryParameters = new QueryString<CreateContainerParameters>(parameters);
 
         var data = new JsonRequestContent<CreateContainerParameters>(parameters, DockerClient.JsonSerializer);
 
@@ -130,10 +126,13 @@ public async Task<MultiplexedStream> GetContainerLogsAsync(string id, ContainerL
         var containerInspectResponse = await InspectContainerAsync(id, cancellationToken)
             .ConfigureAwait(false);
 
+        var containerConfig = containerInspectResponse.Config
+            ?? throw new InvalidOperationException("Container inspect response did not include container configuration.");
+
         var response = await _client.MakeRequestForStreamAsync([NoSuchContainerHandler], HttpMethod.Get, $"containers/{id}/logs", queryParameters, null, null, cancellationToken)
             .ConfigureAwait(false);
 
-        return new MultiplexedStream(response, !containerInspectResponse.Config.Tty);
+        return new MultiplexedStream(response, !containerConfig.Tty);
     }
 
     public async Task<IList<ContainerFileSystemChangeResponse>> InspectChangesAsync(string id, CancellationToken cancellationToken = default)
@@ -350,10 +349,13 @@ public async Task<MultiplexedStream> AttachContainerAsync(string id, ContainerAt
         var containerInspectResponse = await InspectContainerAsync(id, cancellationToken)
             .ConfigureAwait(false);
 
+        var containerConfig = containerInspectResponse.Config
+            ?? throw new InvalidOperationException("Container inspect response did not include container configuration.");
+
         var response = await _client.MakeRequestForHijackedStreamAsync([NoSuchContainerHandler], HttpMethod.Post, $"containers/{id}/attach", queryParameters, null, null, cancellationToken)
             .ConfigureAwait(false);
 
-        return new MultiplexedStream(response, !containerInspectResponse.Config.Tty);
+        return new MultiplexedStream(response, !containerConfig.Tty);
     }
 
     public async Task<ContainerWaitResponse> WaitContainerAsync(string id, CancellationToken cancellationToken = default)

src/Docker.DotNet/Endpoints/ImageOperations.cs

@@ -305,14 +305,25 @@ private static Dictionary<string, string> RegistryAuthHeaders(AuthConfig? authCo
         };
     }
 
-    private static Dictionary<string, string> RegistryConfigHeaders(IEnumerable<AuthConfig>? authConfig)
+    private static Dictionary<string, string> RegistryConfigHeaders(IEnumerable<AuthConfig>? authConfigs)
     {
-        var configDictionary = (authConfig ?? Array.Empty<AuthConfig>()).ToDictionary(e => e.ServerAddress, e => e);
+        var registryAuthConfigurations = new Dictionary<string, AuthConfig>();
+
+        foreach (var registryAuthConfiguration in authConfigs ?? Array.Empty<AuthConfig>())
+        {
+            var registryAddress = registryAuthConfiguration.ServerAddress;
+
+            if (!string.IsNullOrEmpty(registryAddress))
+            {
+                registryAuthConfigurations[registryAddress] = registryAuthConfiguration;
+            }
+        }
+
         return new Dictionary<string, string>
         {
             {
                 RegistryConfigHeaderKey,
-                Convert.ToBase64String(DockerClient.JsonSerializer.SerializeToUtf8Bytes(configDictionary))
+                Convert.ToBase64String(DockerClient.JsonSerializer.SerializeToUtf8Bytes(registryAuthConfigurations))
             }
         };
     }

src/Docker.DotNet/Models/Actor.Generated.cs

@@ -1,11 +1,12 @@
+#nullable enable
 namespace Docker.DotNet.Models
 {
     public class Actor // (events.Actor)
     {
         [JsonPropertyName("ID")]
-        public string ID { get; set; }
+        public string ID { get; set; } = default!;
 
         [JsonPropertyName("Attributes")]
-        public IDictionary<string, string> Attributes { get; set; }
+        public IDictionary<string, string> Attributes { get; set; } = default!;
     }
 }

src/Docker.DotNet/Models/Annotations.Generated.cs

@@ -1,11 +1,12 @@
+#nullable enable
 namespace Docker.DotNet.Models
 {
     public class Annotations // (swarm.Annotations)
     {
         [JsonPropertyName("Name")]
-        public string Name { get; set; }
+        public string? Name { get; set; }
 
         [JsonPropertyName("Labels")]
-        public IDictionary<string, string> Labels { get; set; }
+        public IDictionary<string, string> Labels { get; set; } = default!;
     }
 }

src/Docker.DotNet/Models/AppArmorOpts.Generated.cs

@@ -1,8 +1,9 @@
+#nullable enable
 namespace Docker.DotNet.Models
 {
     public class AppArmorOpts // (swarm.AppArmorOpts)
     {
         [JsonPropertyName("Mode")]
-        public string Mode { get; set; }
+        public string? Mode { get; set; }
     }
 }

src/Docker.DotNet/Models/AttestationProperties.Generated.cs

@@ -1,8 +1,9 @@
+#nullable enable
 namespace Docker.DotNet.Models
 {
     public class AttestationProperties // (image.AttestationProperties)
     {
         [JsonPropertyName("For")]
-        public string For { get; set; }
+        public string For { get; set; } = default!;
     }
 }

src/Docker.DotNet/Models/AuthConfig.Generated.cs

@@ -1,23 +1,24 @@
+#nullable enable
 namespace Docker.DotNet.Models
 {
     public class AuthConfig // (registry.AuthConfig)
     {
         [JsonPropertyName("username")]
-        public string Username { get; set; }
+        public string? Username { get; set; }
 
         [JsonPropertyName("password")]
-        public string Password { get; set; }
+        public string? Password { get; set; }
 
         [JsonPropertyName("auth")]
-        public string Auth { get; set; }
+        public string? Auth { get; set; }
 
         [JsonPropertyName("serveraddress")]
-        public string ServerAddress { get; set; }
+        public string? ServerAddress { get; set; }
 
         [JsonPropertyName("identitytoken")]
-        public string IdentityToken { get; set; }
+        public string? IdentityToken { get; set; }
 
         [JsonPropertyName("registrytoken")]
-        public string RegistryToken { get; set; }
+        public string? RegistryToken { get; set; }
     }
 }

src/Docker.DotNet/Models/AuthResponse.Generated.cs

@@ -1,11 +1,12 @@
+#nullable enable
 namespace Docker.DotNet.Models
 {
     public class AuthResponse // (registry.AuthResponse)
     {
         [JsonPropertyName("IdentityToken")]
-        public string IdentityToken { get; set; }
+        public string? IdentityToken { get; set; }
 
         [JsonPropertyName("Status")]
-        public string Status { get; set; }
+        public string Status { get; set; } = default!;
     }
 }

src/Docker.DotNet/Models/BindOptions.Generated.cs

@@ -1,20 +1,21 @@
+#nullable enable
 namespace Docker.DotNet.Models
 {
     public class BindOptions // (mount.BindOptions)
     {
         [JsonPropertyName("Propagation")]
-        public string Propagation { get; set; }
+        public string? Propagation { get; set; }
 
         [JsonPropertyName("NonRecursive")]
-        public bool NonRecursive { get; set; }
+        public bool? NonRecursive { get; set; }
 
         [JsonPropertyName("CreateMountpoint")]
-        public bool CreateMountpoint { get; set; }
+        public bool? CreateMountpoint { get; set; }
 
         [JsonPropertyName("ReadOnlyNonRecursive")]
-        public bool ReadOnlyNonRecursive { get; set; }
+        public bool? ReadOnlyNonRecursive { get; set; }
 
         [JsonPropertyName("ReadOnlyForceRecursive")]
-        public bool ReadOnlyForceRecursive { get; set; }
+        public bool? ReadOnlyForceRecursive { get; set; }
     }
 }

src/Docker.DotNet/Models/BlkioStatEntry.Generated.cs

@@ -1,17 +1,18 @@
+#nullable enable
 namespace Docker.DotNet.Models
 {
     public class BlkioStatEntry // (container.BlkioStatEntry)
     {
         [JsonPropertyName("major")]
-        public ulong Major { get; set; }
+        public ulong Major { get; set; } = default!;
 
         [JsonPropertyName("minor")]
-        public ulong Minor { get; set; }
+        public ulong Minor { get; set; } = default!;
 
         [JsonPropertyName("op")]
-        public string Op { get; set; }
+        public string Op { get; set; } = default!;
 
         [JsonPropertyName("value")]
-        public ulong Value { get; set; }
+        public ulong Value { get; set; } = default!;
     }
 }