[Bug]: User's module builder configuration gets overwritten by the final `Build()`

[yannic-hamann-abb]

Testcontainers version

4.10.0

Using the latest Testcontainers version?

Yes

Host OS

Windows

Host arch

x86

.NET version

10

Docker version

Docker version 29.2.1, build a5c7197

Docker info

Client:
 Version:    29.2.1
 Context:    desktop-linux
 Debug Mode: false
 Plugins:
  agent: create or run AI agents (Docker Inc.)
    Version:  v1.27.1
    Path:     C:\Program Files\Docker\cli-plugins\docker-agent.exe
  ai: Docker AI Agent - Ask Gordon (Docker Inc.)
    Version:  v1.18.0
    Path:     C:\Program Files\Docker\cli-plugins\docker-ai.exe
  buildx: Docker Buildx (Docker Inc.)
    Version:  v0.31.1-desktop.1
    Path:     C:\Program Files\Docker\cli-plugins\docker-buildx.exe
  compose: Docker Compose (Docker Inc.)
    Version:  v5.1.0
    Path:     C:\Program Files\Docker\cli-plugins\docker-compose.exe
  debug: Get a shell into any image or container (Docker Inc.)
    Version:  0.0.47
    Path:     C:\Program Files\Docker\cli-plugins\docker-debug.exe
  desktop: Docker Desktop commands (Docker Inc.)
    Version:  v0.3.0
    Path:     C:\Program Files\Docker\cli-plugins\docker-desktop.exe
  extension: Manages Docker extensions (Docker Inc.)
    Version:  v0.2.31
    Path:     C:\Program Files\Docker\cli-plugins\docker-extension.exe
  init: Creates Docker-related starter files for your project (Docker Inc.)
    Version:  v1.4.0
    Path:     C:\Program Files\Docker\cli-plugins\docker-init.exe
  mcp: Docker MCP Plugin (Docker Inc.)
    Version:  v0.40.2
    Path:     C:\Program Files\Docker\cli-plugins\docker-mcp.exe
  model: Docker Model Runner (Docker Inc.)
    Version:  v1.1.5
    Path:     C:\Program Files\Docker\cli-plugins\docker-model.exe
  offload: Docker Offload (Docker Inc.)
    Version:  v0.5.56
    Path:     C:\Program Files\Docker\cli-plugins\docker-offload.exe
  pass: Docker Pass Secrets Manager Plugin (beta) (Docker Inc.)
    Version:  v0.0.24
    Path:     C:\Program Files\Docker\cli-plugins\docker-pass.exe
  sandbox: Docker Sandbox (Docker Inc.)
    Version:  v0.12.0
    Path:     C:\Program Files\Docker\cli-plugins\docker-sandbox.exe
  sbom: View the packaged-based Software Bill Of Materials (SBOM) for an image (Anchore Inc.)
    Version:  0.6.0
    Path:     C:\Program Files\Docker\cli-plugins\docker-sbom.exe
  scout: Docker Scout (Docker Inc.)
    Version:  v1.20.0
    Path:     C:\Program Files\Docker\cli-plugins\docker-scout.exe

Server:
 Containers: 12
  Running: 0
  Paused: 0
  Stopped: 12
 Images: 137
 Server Version: 29.2.1
 Storage Driver: overlay2
  Backing Filesystem: extfs
  Supports d_type: true
  Using metacopy: false
  Native Overlay Diff: true
  userxattr: false
 Logging Driver: json-file
 Cgroup Driver: cgroupfs
 Cgroup Version: 1
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local splunk syslog
 CDI spec directories:
  /etc/cdi
  /var/run/cdi
 Discovered Devices:
  cdi: docker.com/gpu=webgpu
 Swarm: inactive
 Runtimes: nvidia runc io.containerd.runc.v2
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: dea7da592f5d1d2b7755e3a161be07f43fad8f75
 runc version: v1.3.4-0-gd6d73eb8
 init version: de40ad0
 Security Options:
  seccomp
   Profile: builtin
 Kernel Version: 5.15.153.1-microsoft-standard-WSL2
 Operating System: Docker Desktop
 OSType: linux
 Architecture: x86_64
 CPUs: 20
 Total Memory: 15.46GiB
 Name: docker-desktop
 ID: eac52a52-36e3-4060-a6fc-2f4c8d68b4d7
 Docker Root Dir: /var/lib/docker
 Debug Mode: false
 HTTP Proxy: http.docker.internal:3128
 HTTPS Proxy: http.docker.internal:3128
 No Proxy: hubproxy.docker.internal
 Labels:
  com.docker.desktop.address=npipe://\\.\pipe\docker_cli
 Experimental: false
 Insecure Registries:
  hubproxy.docker.internal:5555
  ::1/128
  127.0.0.0/8
 Live Restore Enabled: false
 Firewall Backend: iptables

WARNING: No blkio throttle.read_bps_device support
WARNING: No blkio throttle.write_bps_device support
WARNING: No blkio throttle.read_iops_device support
WARNING: No blkio throttle.write_iops_device support
WARNING: Support for cgroup v1 is deprecated and planned to be removed by no later than May 2029 (https://github.com/moby/moby/issues/51111

What happened?

Kafka = new KafkaBuilder("confluentinc/cp-kafka:7.8.1")
     .WithEnvironment("KAFKA_CREATE_TOPICS", "topic-name")
     .WithStartupCallback((container, ct) => { return Task.CompletedTask; })
     .WithPortBinding(9092, true)
     .Build();
// ...
await Kafka.StartAsync()

When I successfully start the container the startup callback isn't invoked.
I suspect the reason for that is that my custom callback is potentially overwritten here,

If this is the case this bug also applies to other containers.

Relevant log output

-

Additional information

No response

[coderabbitai]

🔗 Related PRs

#1604 - fix(Kafka): Bump image version to prevent container crash on startup [merged]
#1624 - fix(EventHubs): Workaround health API timeout [merged]

---

📝 Issue Planner

_{Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.}

• Create Plan

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!

[HofmeisterAn]

I suspect the reason for that is that my custom callback is potentially overwritten here,

Yep. Unfortunately, your configuration has been overwritten. Modules are pre-configured and opinionated, which makes it challenging to provide reliable modules while allowing maximum customization. Kafka, in particular, is a very complex module. If you need to apply customizations at this level, I recommend using the generic container builder. This gives you maximum flexibility, and you can even implement your own custom module based on it.

What kind of customization do you need? Maybe you could use events or copy a script to run after the container starts?

That said, we should make it clearer for developers when a configuration is overwritten by Build(), so users are aware of this behavior.

[yannic-hamann-abb]

Thanks Andre, you are awesome. I simply need to create some topics at startup before my integration tests run.
I cannot create topics on publish because I am using the MassTransit Kafka rider that requries the topic to be created beforehand.

I know that I can solve this by simply creating the topic after the container started before starting my tests.
But I thought that this behavior is odd and misleading so I created the bug in case you weren't aware.

I am still exploring the setup and on second thought the server isn't even ready in the callback. So my use case is irrelevant.

When I searched the repo I saw that other containers have the same overwrite behavior, but not all.

[HofmeisterAn]

When I searched the repo I saw that other containers have the same overwrite behavior, but not all.

For wait strategies, the modules usually use the user-selected configuration, but you're right, the pattern isn't used for all configurations.