feat: Add Valkey module support#1508
Closed
thomhurst wants to merge 3 commits intotestcontainers:developfrom
Closed
feat: Add Valkey module support#1508thomhurst wants to merge 3 commits intotestcontainers:developfrom
thomhurst wants to merge 3 commits intotestcontainers:developfrom
Conversation
Add Testcontainers module for Valkey, a Redis-compatible in-memory data store. Includes ValkeyContainer implementation with connection string support and comprehensive tests. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Add Testcontainers.Valkey to CI/CD test matrix in workflow - Create comprehensive documentation for Valkey module - Add Valkey to modules index with Docker image and links 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
HofmeisterAn
added
module
HofmeisterAn
force-pushed
the
develop
branch
3 times, most recently
from
4900ecd to
8fa5f1b
Compare
Collaborator
HofmeisterAn
left a comment
HofmeisterAn
left a comment
There was a problem hiding this comment.
Thanks for the PR. I'll close this in favor of: #1641.
The Redis module should be compatible with the container image. I'd like to reduce the number of copy-paste modules and the associated maintenance work. If Valkey introduces features or configuration options that require dedicated support in the future, we can add a separate module at that time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Testcontainers module for Valkey, a Redis-compatible in-memory data store. Includes ValkeyContainer implementation with connection string support and tests.