Update MsSql image to 2025-RTM-ubuntu-22.04#1595
Update MsSql image to 2025-RTM-ubuntu-22.04#1595XmlmXmlmX wants to merge 2 commits intotestcontainers:developfrom
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughUpdated the MsSqlBuilder.MsSqlImage constant to reference the SQL Server 2025 RTM Ubuntu container image instead of the previous 2022 CU14 image. No other code, logic, or error handling changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5–10 minutes
Possibly related issues
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings📚 Learning: 2025-11-17T17:58:43.958ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/Testcontainers.MsSql/MsSqlBuilder.cs(2 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: diegosasw
Repo: testcontainers/testcontainers-dotnet PR: 1583
File: src/Testcontainers.KurrentDb/Testcontainers.KurrentDb.csproj:7-7
Timestamp: 2025-11-17T17:58:43.958Z
Learning: In the testcontainers-dotnet repository, JetBrains.Annotations should use version 2023.3.0 to maintain consistency with the main Testcontainers csproj, rather than always using the latest available version.
📚 Learning: 2025-11-17T17:58:43.958Z
Learnt from: diegosasw
Repo: testcontainers/testcontainers-dotnet PR: 1583
File: src/Testcontainers.KurrentDb/Testcontainers.KurrentDb.csproj:7-7
Timestamp: 2025-11-17T17:58:43.958Z
Learning: In the testcontainers-dotnet repository, JetBrains.Annotations should use version 2023.3.0 to maintain consistency with the main Testcontainers csproj, rather than always using the latest available version.
Applied to files:
src/Testcontainers.MsSql/MsSqlBuilder.cs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: ci (Testcontainers, ubuntu-24.04)
- GitHub Check: ci (Testcontainers.MsSql, ubuntu-24.04)
- GitHub Check: analyze (csharp)
XmlmXmlmX
changed the title
|
We don't update image versions for modules unless it's absolutely necessary to prevent introducing breaking changes. We recommend that developers overwrite and pin their required versions instead. We're even considering removing the default image to encourage developers to set the image explicitly. |
Ok, understand. So the solution is to use: new MsSqlBuilder().WithImage("mcr.microsoft.com/mssql/server:2025-latest").Build(); |
2 participants
What does this PR do?
I changed the docker container version to
mcr.microsoft.com/mssql/server:2025-RTM-ubuntu-22.04.Why is it important?
The current version
2022-CU14-ubuntu-22.04does not support the latest features like json columns.Related issues
2022-latestdoes not supportjsoncolumn type microsoft/aspire#13084How to test this PR
Create a entity configration and use
.ToJson()inEntityTypeBuilder.SQL Server 2025 Breaking Changes – Summary
Major Breaking Changes
Linked Server Connections
Encryptparameter) and valid TLS certificates; legacy/unsecured connections may break.Replication & Log Shipping
Legacy Feature Removal
Security Defaults
Database Engine & Query Processing
Automation & .NET Providers
Microsoft.Data.SqlClient—the oldSystem.Data.SqlClientprovider is unsupported and must be replaced.Key Takeaway:
SQL Server 2025 enforces stricter security defaults, retires multiple legacy features, and updates data provider compatibility. Review all code and deployment tools for compatibility before upgrading.
Reference Links: