-
-
Notifications
You must be signed in to change notification settings - Fork 345
feat: Add Platform property to IImage interface #1610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4f4b6ad
feat: Add Platform property to IImage interface
HofmeisterAn c1b76c5
docs: Add platform doc
HofmeisterAn 3dfe17a
fix: Add Platform type
HofmeisterAn f2bf9d7
fix: Set Platform.Value
HofmeisterAn eb674c8
fix: Use correct ctor
HofmeisterAn 09ea9c1
chore: Apply suggestions
HofmeisterAn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| namespace DotNet.Testcontainers.Images | ||
| { | ||
| using JetBrains.Annotations; | ||
|
|
||
| /// <summary> | ||
| /// Represents a container platform identifier. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// The supported format for a platform value is: | ||
| /// <c><os>|<arch>|<os>/<arch>[/<variant>]</c>. | ||
| /// | ||
| /// You can provide either the operating system or the architecture or both. | ||
| /// For more details, see <see href="https://github.com/containerd/platforms">containerd/platforms</see>. | ||
| /// </remarks> | ||
| [PublicAPI] | ||
| public readonly struct Platform | ||
| { | ||
| /// <summary> | ||
| /// Initializes a new instance of the <see cref="Platform" /> struct. | ||
| /// </summary> | ||
| /// <param name="value">The platform identifier.</param> | ||
| [PublicAPI] | ||
| public Platform(string value) | ||
| { | ||
| Value = value; | ||
| } | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| /// <summary> | ||
| /// Gets the platform identifier. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// A string representing the container platform in <c>containerd/platforms</c> format, or | ||
| /// <c>null</c> if no platform was specified. | ||
| /// </remarks> | ||
| [PublicAPI] | ||
| [CanBeNull] | ||
| public string Value { get; } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.