chore: Bump Docker Engine API to 1.52#1633
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughThe CI workflow's Docker API version environment variable is updated from 1.47 to 1.52 in the cicd.yml configuration file. This is a configuration-only change with no modifications to workflow logic or control flow. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/cicd.yml:
- Around line 65-66: The comment describing DOCKER_API_VERSION is misleading:
update the comment that currently reads "Lowest API version that GitHub runners
support" to clarify that DOCKER_API_VERSION: 1.52 is the maximum API version
Docker.DotNet is built against (Docker Engine v29 supports API 1.44–1.52), so
change the comment to state it's the maximum supported API version (or the API
version Docker.DotNet targets) to avoid implying it is the minimum; locate the
DOCKER_API_VERSION setting in the workflow and replace the comment accordingly.
What does this PR do?
The GitHub-hosted runners have updated Docker. The Docker Engine is now v29, which corresponds to the Docker Engine API 1.52. This PR updates the CI configuration to bump the pinned version. This version is now the one Docker.DotNet is built against. No version downgrade.
Why is it important?
Related issues
Summary by CodeRabbit