Skip to content

docs(Redis): Add example#1641

Merged
HofmeisterAn merged 5 commits intodevelopfrom
docs/add-redis-garnet-valkey-docs
Feb 28, 2026
Merged

docs(Redis): Add example#1641
HofmeisterAn merged 5 commits intodevelopfrom
docs/add-redis-garnet-valkey-docs

Conversation

@HofmeisterAn
Copy link
Copy Markdown
Collaborator

@HofmeisterAn HofmeisterAn commented Feb 28, 2026

What does this PR do?

This PR adds a simple Redis example to the docs. It also includes a brief note about Garnet and Valkey, mentioning that both are compatible with the Redis module and don’t require a separate module at this time.

Why is it important?

-

Related issues

Summary by CodeRabbit

  • Documentation

    • Added Garnet, Redis, and Valkey integration guides and added their pages to navigation
    • Added KurrentDb, Ollama, Seq, and Temporal entries to the modules index (duplicated in two sections)
    • Minor wording and admonition formatting refinements across several docs (Qdrant, API pages, call-outs)
  • Tests

    • Small test updates and comment markers; GUID strings explicitly formatted with hyphens in two tests (no behavior changes)

@HofmeisterAn HofmeisterAn added the documentation Docs, docs, docs. label Feb 28, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 28, 2026

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit c541a46
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-dotnet/deploys/69a2a07e942ed2000821c025
😎 Deploy Preview https://deploy-preview-1641--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a9a39dd and c541a46.

📒 Files selected for processing (1)
  • docs/modules/valkey.md

Walkthrough

Adds three new module docs (Garnet, Redis, Valkey), updates the modules index and mkdocs navigation, normalizes Markdown admonition spacing across docs, and makes minor test edits (GUID formatting and comment region markers). No public API or behavioral changes.

Changes

Cohort / File(s) Summary
New module docs
docs/modules/garnet.md, docs/modules/redis.md, docs/modules/valkey.md
Added documentation pages describing Garnet/Redis/Valkey usage with Testcontainers.Redis, installation and usage examples, and test project callouts.
Modules index & nav
docs/modules/index.md, mkdocs.yml
Inserted new module entries (KurrentDb, Ollama, Seq, Temporal) into the modules index and added garnet.md, redis.md, and valkey.md to site navigation.
Documentation formatting fixes
docs/api/..., docs/custom_configuration/index.md, docs/modules/qdrant.md, docs/modules/_call_out_test_projects.txt, docs/test_frameworks/xunit_net.md
Standardized Markdown admonition spacing (e.g., !!! tip, !!! note, !!! warning) and a small wording tweak in Qdrant doc.
Test edits — GUID formatting
tests/Testcontainers.EventHubs.Tests/EventHubsContainerTest.cs, tests/Testcontainers.OpenSearch.Tests/OpenSearchContainerTest.cs
Reformatted GUID string serialization to Guid.ToString("D") for explicit hyphenated GUIDs.
Test edits — comments/regions
tests/Testcontainers.Redis.Tests/RedisContainerTest.cs, tests/Testcontainers.Redis.Tests/Testcontainers.Redis.Tests.csproj
Added comment region markers around Redis usage and package references; no functional or dependency changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇
I hopped through pages, soft and spry,
Garnet, Redis, Valkey standing by.
I nudged the index, tidied the tips,
Left tests with gentle, hyphenated sips.
A rabbit's cheer for docs that fly! ✨

🚥 Pre-merge checks | ❌ 5

❌ Failed checks (3 warnings, 2 inconclusive)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR adds documentation for Redis, Garnet, and Valkey modules with example usage, partially addressing the linked issues. However, it lacks actual test implementations (GarnetContainerTest.cs) and a dedicated ValkeyContainer class as requested in issues #1225 and #1508. Add GarnetContainerTest.cs implementation and create a dedicated ValkeyContainer class with connection string support and accompanying tests to fully satisfy issue requirements.
Out of Scope Changes check ⚠️ Warning The PR includes numerous unrelated documentation formatting changes (Markdown admonition syntax corrections from '!!!note' to '!!! note') and test file modifications that are not directly tied to the Redis, Garnet, or Valkey documentation objectives. Remove out-of-scope formatting changes to admonition directives and unrelated test modifications; focus on documentation and test implementations directly related to Redis, Garnet, and Valkey.
Docstring Coverage ⚠️ Warning Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'docs(Redis): Add example' is vague and incomplete. While it mentions Redis, it doesn't convey that the PR also addresses Garnet and Valkey documentation, which are substantial parts of the changeset. Consider a more comprehensive title like 'docs: Add Redis, Garnet, and Valkey examples' to better reflect all significant documentation additions in this PR.
Description check ❓ Inconclusive The description is incomplete. The 'Why is it important?' section is empty (only contains '-'), and no 'How to test this PR' section is provided despite the template recommending it. Complete the 'Why is it important?' section with rationale and optionally add a 'How to test this PR' section with verification steps.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch docs/add-redis-garnet-valkey-docs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/modules/garnet.md`:
- Around line 6-8: Update the MkDocs markup in the Garnet module text: change
the admonition token `!!!note` to `!!! note` and fix the relative link
`(modules/redis/)` to use the site-root relative path `/modules/redis/` so it
matches other module pages (search for the `!!!note` token and the
`(modules/redis/)` link in the Garnet content to locate the lines to edit).

In `@docs/modules/valkey.md`:
- Around line 6-8: Replace the incorrect Garnet wording and fix the Markdown
syntax: change the phrase "Garnet module" to "Valkey module", update the inline
link target from `modules/redis/` to the absolute path format
`(/modules/redis/)`, and correct the admonition marker `!!!note` to `!!! note`
(so the note block renders properly). Ensure these edits apply where the text
mentions `Testcontainers.Redis` and the surrounding admonition.

ℹ️ Review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5e97c58 and 66f48a2.

📒 Files selected for processing (10)
  • docs/modules/garnet.md
  • docs/modules/index.md
  • docs/modules/qdrant.md
  • docs/modules/redis.md
  • docs/modules/valkey.md
  • mkdocs.yml
  • tests/Testcontainers.EventHubs.Tests/EventHubsContainerTest.cs
  • tests/Testcontainers.OpenSearch.Tests/OpenSearchContainerTest.cs
  • tests/Testcontainers.Redis.Tests/RedisContainerTest.cs
  • tests/Testcontainers.Redis.Tests/Testcontainers.Redis.Tests.csproj

Comment thread docs/modules/garnet.md Outdated
Comment thread docs/modules/valkey.md Outdated
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ Duplicate comments (1)
docs/modules/valkey.md (1)

5-5: ⚠️ Potential issue | 🟡 Minor

Correct copy-paste error: "Garnet module" should be "Valkey module".

Line 5 incorrectly references "Garnet module" in the Valkey documentation. This appears to be a copy-paste error from the Garnet docs.

📝 Proposed fix
-You can use the existing [`Testcontainers.Redis`](/modules/redis/) package without requiring a separate Garnet module.
+You can use the existing [`Testcontainers.Redis`](/modules/redis/) package without requiring a separate Valkey module.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@docs/modules/valkey.md` at line 5, The sentence in docs/modules/valkey.md
incorrectly says "Garnet module" due to a copy-paste error; update that text to
read "Valkey module" so the line reads that Testcontainers.Redis can be used
without requiring a separate Valkey module (replace the phrase "Garnet module"
with "Valkey module" in the affected sentence).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@docs/modules/valkey.md`:
- Line 5: The sentence in docs/modules/valkey.md incorrectly says "Garnet
module" due to a copy-paste error; update that text to read "Valkey module" so
the line reads that Testcontainers.Redis can be used without requiring a
separate Valkey module (replace the phrase "Garnet module" with "Valkey module"
in the affected sentence).

ℹ️ Review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 66f48a2 and a9a39dd.

📒 Files selected for processing (12)
  • docs/api/connection_string_provider.md
  • docs/api/create_docker_container.md
  • docs/api/create_docker_image.md
  • docs/api/resource_reaper.md
  • docs/api/resource_reuse.md
  • docs/api/wait_strategies.md
  • docs/custom_configuration/index.md
  • docs/modules/_call_out_test_projects.txt
  • docs/modules/garnet.md
  • docs/modules/valkey.md
  • docs/test_frameworks/xunit_net.md
  • mkdocs.yml
✅ Files skipped from review due to trivial changes (7)
  • docs/api/create_docker_container.md
  • docs/api/connection_string_provider.md
  • docs/api/create_docker_image.md
  • docs/custom_configuration/index.md
  • docs/test_frameworks/xunit_net.md
  • docs/api/wait_strategies.md
  • docs/api/resource_reaper.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • mkdocs.yml

@HofmeisterAn HofmeisterAn merged commit a8482b5 into develop Feb 28, 2026
14 checks passed
@HofmeisterAn HofmeisterAn deleted the docs/add-redis-garnet-valkey-docs branch February 28, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Docs, docs, docs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant