-
-
Notifications
You must be signed in to change notification settings - Fork 345
fix: Trim tar record padding to avoid broken-pipe failure on Podman #1684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
HofmeisterAn
merged 5 commits into
testcontainers:develop
from
artiomchi:bugfix/fix-tar-padding-pipe-failure-on-podman
Apr 27, 2026
+19
−5
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
015eb32
Trim tar record padding to avoid broken-pipe failure on Podman
artiomchi b7674d4
Fix broken solution references
artiomchi 204853c
chore Align tar block factor usage across archive writers
HofmeisterAn 8ae4c9c
fix: Add missing using
HofmeisterAn a798cbc
chore: Move TarBlockFactor to shared class
HofmeisterAn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| namespace DotNet.Testcontainers | ||
| { | ||
| internal static class TarArchiveDefaults | ||
| { | ||
| // Keep the record size equal to the block size (512 B) so SharpZipLib does | ||
| // not write extra zero padding beyond the two standard EOF blocks. The | ||
| // default factor of 20 produces ~8 KB of zeros after EOF, which can trigger | ||
| // a race in Podman's archive handler. The tar subprocess exits after the EOF | ||
| // blocks while the HTTP sender is still flushing the padding, causing EPIPE | ||
| // (HTTP 500 "broken pipe"). See: | ||
| // https://github.com/testcontainers/testcontainers-dotnet/issues/1683. | ||
| internal const int TarBlockFactor = 1; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.