feat(container): Add Mongo DB container#251
Conversation
|
Irrelevant /Users/Ivan path. Pr description auto generated ? |
jarlah
left a comment
There was a problem hiding this comment.
A couple of comments from me looking at the code. I think the most "important" was a missing function comment/doc.
jarlah
left a comment
There was a problem hiding this comment.
Exact failure on all versions. Maybe run tests locally and fix the test failures?
|
@jarlah sorry to bother you, but for DBs containers is needed to update There we have some implementation via mix task. |
No. Thats just for phoenix apps. No need |
|
@jarlah I hope you are doing great, I already solved most of the comments, I'll apreciate if you can re take a look and let me know if missing something else. |
|
great work :) i just need you to bump to latest version of the mongo dep |
|
Thanks by the feedback :) @jarlah |
jarlah
left a comment
There was a problem hiding this comment.
Simple, focused, works. I will fix the flaky test
|
Are you ok with squashing? Or do you want to rebase your commits ? |
|
Yeap I'm OK with squashing |
|
Might not release just yet. But you can point to master until i do |
Eyyy Guys I hope you're doing great here is a PR for MongoDB implementation inspired from Ruby TestContainers.
PR Title
Add new MongoContainer implementation from scratch with Ruby-parity behavior and comprehensive tests
Summary
This PR introduces a brand new MongoContainer implementation for testcontainers-elixir, modeled after testcontainers-ruby Mongo behavior and adapted to Elixir conventions.
It also adds comprehensive test coverage, including a real reachability test against a running Mongo container.
What was added
1) New Mongo container module
Created lib/container/mongo_container.ex (testcontainers-elixir/lib/container/mongo_container.ex) from scratch with: